1610736 - Uncomment calls to moz_dispose_arena

Status: NEW

(Core :: JavaScript Engine, task, P3)

Description

[Mike Hommey [:glandium]]

Bug 1610720 modifies how moz_dispose_arena works, and as long as the arena is empty before calling it, it is safe to call it.

Assuming the arenas are empty when js::ShutDownMallocAllocator is called, it is now possible to uncomment the calls.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1610736 - Uncomment calls to moz_dispose_arena.

Bug 1610720 modifies how moz_dispose_arena works, and as long as the
arena is empty before calling it, it is safe to call it.

Comment 2

[BugBot [:suhaib / :marco]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:glandium, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 3

[Mike Hommey [:glandium]]

Assuming the arenas are empty when js::ShutDownMallocAllocator is called, it is now possible to uncomment the calls.

Of course, they still aren't.

Comment 4

[Paul Bone [:pbone]]

Once Bug 1364359 lands then it won't matter that the arenas are non-empty, they will be destroyed once their last item is freed.