Closed Bug 1610766 Opened 5 years ago Closed 5 years ago

turn the settled hardcoded value into an option

Categories

(Testing :: Raptor, enhancement, P3)

Version 3
enhancement

Tracking

(firefox77 fixed)

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: tarek, Assigned: myeongjun.ko, Mentored)

Details

(Whiteboard: [lang=py])

User Story

See here for information on how to contribute: https://wiki.mozilla.org/TestEngineering/Performance/NewContributors

Attachments

(1 file, 4 obsolete files)

Let's add a new --conditioned-profile-scenario option so we can override "settled"

we should also include the profile used in extraOptions so Perfherder doesn't conflate these results.

Mentor: gmierz2
Priority: -- → P3
Whiteboard: [lang=py]
User Story: (updated)
Keywords: good-first-bug

Tarek, could you please give some more details in what exactly needs to be changed? From the perspective of a mentored bug it currently contains no information for a contributor. Also I think it's not necessarily a good first bug.

Flags: needinfo?(tarek)
Keywords: good-first-bug

raptor harcodes the conditioned profile that is used: https://searchfox.org/mozilla-central/source/testing/raptor/raptor/perftest.py#203

if we can have this as a parameter, it allows us to pick another profile in our tests, in mach try or locally.

Flags: needinfo?(tarek)
Assignee: nobody → lsackash
Status: NEW → ASSIGNED

What is raptor for and why someone would need to apply a different profile? The info I could find about raptor on MDN docs mostly referred to it in conjunction with the discontinued FirefoxOS. The Mozilla codebase is much larger than anything I’ve worked on before and it’s taking me a while to wrap my head around it.

Flags: needinfo?(gmierz2)

Hi Luke, you can find most of that information in the new contributors guide: https://wiki.mozilla.org/TestEngineering/Performance/NewContributors

Here's more information on Raptor: https://wiki.mozilla.org/TestEngineering/Performance/Raptor

Raptor is one of our Performance Testing frameworks and the different conditioned profiles represent different styles of how a browser it used. For instance, the "heavy" profile would be a user profile that is generated from heavy usage of the browser. These different profiles let us make our pageload tests in Raptor be more realistic or representative of what a user might actually see in the wild (rather than always testing with a completely blank profile which isn't very common in reality).

Flags: needinfo?(gmierz2)
Attachment #9128588 - Attachment is obsolete: true
Attachment #9129880 - Attachment is obsolete: true
Attachment #9130854 - Attachment description: Bug 1610766 add '--conditioned-profile-scenario' as a command line option to raptor and attempt to use user assigned path instead of the default. r=sparky → Bug 1610766 - Add --conditioned-profile-scenario as a command line option to raptor. r?sparky
Attachment #9130875 - Attachment is obsolete: true

Luke, are you still working on this issue?

Flags: needinfo?(lsackash)

I will open this to others now.

Assignee: lsackash → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(lsackash)
Assignee: nobody → myeongjun.ko
Status: NEW → ASSIGNED
Attachment #9138887 - Attachment description: Bug 1610766 - turn the settled hardcoded value into an option how to add --conditioned-profile-scenario r=sparky → Bug 1610766 - Add option to set conditioned-profile type to Raptor/Browsertime. r?sparky
Attachment #9138887 - Attachment description: Bug 1610766 - Add option to set conditioned-profile type to Raptor/Browsertime. r?sparky → Bug 1610766 - turn the settled hardcoded value into an option how to add --conditioned-profile-scenario r=sparky
Attachment #9138887 - Attachment description: Bug 1610766 - turn the settled hardcoded value into an option how to add --conditioned-profile-scenario r=sparky → Bug 1610766 - Add option to set conditioned-profile type to Raptor/Browsertime. r?sparky
Pushed by gmierz2@outlook.com: https://hg.mozilla.org/integration/autoland/rev/40c1f2ea5fbe Add option to set conditioned-profile type to Raptor/Browsertime. r=sparky,perftest-reviewers
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
Attachment #9130854 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: