Closed
Bug 1610781
Opened 4 years ago
Closed 4 years ago
Add react-dom file to React regex in getLibraryFromUrl
Categories
(DevTools :: Shared Components, task, P2)
DevTools
Shared Components
Tracking
(firefox74 fixed)
RESOLVED
FIXED
Firefox 74
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
Details
Attachments
(1 file)
This is something that would benefit DevTools engineers as we do load the react-dom.js file, but it isn't put in the React group.
As a result stacktrace are not as clean as they could be.
|
Assignee | |
Comment 1•4 years ago
|
||
The react-dom file is only handled when it originates from node_modules.
This means we won't add it to the React group in stacktrace if it's loaded
as an independent file, like it's done in the devtools codebase for instance.
This patch fixes that and adds a few test cases to ensure this works
as expected.
|
||
Updated•4 years ago
|
Attachment #9122312 -
Attachment description: Bug 1610781 - Ensure react-dom.js file are considered as part of React. r=jlast. → Bug 1610781 - Ensure react-dom.js files are considered as part of React. r=jlast.
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8cfe96fdd1ec Ensure react-dom.js files are considered as part of React. r=jlast.
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox74:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
You need to log in
before you can comment on or make changes to this bug.
Description
•