Closed Bug 1610797 Opened 8 months ago Closed 3 months ago

Crash in [@ nsLDAPSSLClose]

Categories

(Thunderbird :: General, defect)

x86
All
defect
Not set
normal

Tracking

(thunderbird78 fixed)

RESOLVED FIXED
Thunderbird 79.0
Tracking Status
thunderbird78 --- fixed

People

(Reporter: wsmwk, Assigned: mkmelin)

References

Details

(Keywords: crash, regression)

Crash Data

Attachments

(1 file)

crash is new with 68.3.0. Variety of crash addresses

bp-41813288-f64c-4e5d-9b6b-ca7a50191205 68.3.0 0x0
bp-8b31771c-b470-4865-b0ce-073500200122 68.4.1 0xffffffffffffffff
bp-0f3ae5b5-522c-48d8-8d01-589c00200122. 68.4.1 0xff1471ff

Top 10 frames of crashing thread:

0 xul.dll nsLDAPSSLClose comm/ldap/xpcom/src/nsLDAPSecurityGlue.cpp:70
1 ldap60.dll nsldapi_close_connection comm/ldap/c-sdk/libraries/libldap/os-ip.c:737
2 ldap60.dll nsldapi_free_connection comm/ldap/c-sdk/libraries/libldap/request.c:761
3 ldap60.dll nsldapi_free_request comm/ldap/c-sdk/libraries/libldap/request.c:953
4 ldap60.dll nsldapi_free_request comm/ldap/c-sdk/libraries/libldap/request.c:949
5 ldap60.dll nsldapi_result_nolock comm/ldap/c-sdk/libraries/libldap/result.c:134
6 ldap60.dll ldap_result comm/ldap/c-sdk/libraries/libldap/result.c:104
7 xul.dll nsLDAPConnectionRunnable::Run comm/ldap/xpcom/src/nsLDAPConnection.cpp:626
8 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1175
9 xul.dll NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:486

Flags: needinfo?(benc)

So far, only version 68. ~top50 when including prldap_get_socket_info bp-a4ddc8df-4108-49c1-b8da-ff3240200214

Crash Signature: [@ nsLDAPSSLClose] → [@ nsLDAPSSLClose] [@ prldap_get_socket_info ]
Version: unspecified → 68

For some reason there is no soinfo_appdata.

Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #9155635 - Flags: review?(benc)
Comment on attachment 9155635 [details] [diff] [review]
bug1610797_ldap_socketSesssion_crash.patch

Review of attachment 9155635 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Perhaps it could be a StartTLS connection which was never upgraded? (eg shutting down before the StartTLS completed, or even where the server didn't support StartTLS after all...)
Attachment #9155635 - Flags: review?(benc) → review+
Target Milestone: --- → Thunderbird 79.0

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/98363486b335
Fix crash in [@ nsLDAPSSLClose]. r=benc

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Comment on attachment 9155635 [details] [diff] [review]
bug1610797_ldap_socketSesssion_crash.patch

Review of attachment 9155635 [details] [diff] [review]:
-----------------------------------------------------------------

Crash fix.
Attachment #9155635 - Flags: approval-comm-beta?
Comment on attachment 9155635 [details] [diff] [review]
bug1610797_ldap_socketSesssion_crash.patch

Approved for beta.
Flags: needinfo?(benc)
Attachment #9155635 - Flags: approval-comm-beta? → approval-comm-beta+

(In reply to Wayne Mery (:wsmwk) from comment #9)

Ben, would it be expected for these crash signatures to plummet with the release of 68.7.0 from your fixing of Bug 1063723 ? - crash in nsDocumentViewer::OnDonePrinting @ address 0x5a5a5a5a/e5e5e5e9 use-afer-free (plummeted, but did not completely go away)

No, I wouldn't expect any correlation between this and Bug 1063723 - even if the ultimate error (accessing bad memory) is the same, they get there via very different paths.

Flags: needinfo?(benc)
You need to log in before you can comment on or make changes to this bug.