[wpt-sync] Sync PR 21342 - The deference null_ptr for shadow list type
Categories
(Core :: CSS Transitions and Animations, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 21342 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/21342
Details from upstream follow.
haozhe <haozhes@chromium.org> wrote:
The deference null_ptr for shadow list type
The current code doesn't catch the case where non_interpolatable_value
is null for the interpolation_list. This patch add the protection for
this situation.Bug:1039733
Change-Id: I442a56e4984285dfe524dcd669fae9f4da0a7f94
Reviewed-on: https://chromium-review.googlesource.com/2011167
WPT-Export-Revision: 3c33c83bb6dc57152e33d1f6b2fdcc239d3525a8
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=2c1d3fd737e729a30e029a5716786bab3d8e18ca
|
|
Assignee | |
Comment 2•4 years ago
|
||
CI Results
Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 2 tests and 30 subtests
Status Summary
Firefox
OK : 2
PASS : 64
FAIL : 6
Chrome
CRASH: 2
Safari
OK : 2
PASS : 14
FAIL : 56
Links
Details
New Tests That Don't Pass
/css/css-backgrounds/animations/box-shadow-composition.html
Compositing: property <box-shadow> underlying [rgb(10, 20, 30) 1px 2px 3px 4px, rgb(20, 40, 60) 2px 4px 6px 8px] from add [rgb(100, 100, 100) 10px 20px 30px 40px] to replace [rgb(200, 200, 200) 20px 40px 60px 80px] at (1) should be [rgb(200, 200, 200) 20px 40px 60px 80px]: FAIL (Safari: PASS)
Compositing: property <box-shadow> underlying [rgb(10, 20, 30) 1px 2px 3px 4px, rgb(20, 40, 60) 2px 4px 6px 8px, rgb(40, 80, 120) 4px 8px 12px 16px] from add [rgb(100, 100, 100) 10px 20px 30px 40px, rgb(200, 200, 200) 20px 40px 60px 80px] to replace [rgb(200, 200, 200) 20px 40px 60px 80px] at (1) should be [rgb(200, 200, 200) 20px 40px 60px 80px]: FAIL (Safari: FAIL)
Compositing: property <box-shadow> underlying [rgb(10, 20, 30) 1px 2px 3px 4px, rgb(20, 40, 60) 2px 4px 6px 8px] from replace [rgb(100, 100, 100) 10px 20px 30px 40px] to add [rgb(200, 200, 200) 20px 40px 60px 80px] at (0) should be [rgb(100, 100, 100) 10px 20px 30px 40px]: FAIL (Safari: PASS)
/css/css-transitions/animations/text-shadow-composition.html
Compositing: property <text-shadow> underlying [rgb(10, 20, 30) 1px 2px 3px, rgb(20, 40, 60) 2px 4px 6px] from add [rgb(100, 100, 100) 10px 20px 30px] to replace [rgb(200, 200, 200) 20px 40px 60px] at (1) should be [rgb(200, 200, 200) 20px 40px 60px]: FAIL (Safari: PASS)
Compositing: property <text-shadow> underlying [rgb(10, 20, 30) 1px 2px 3px, rgb(20, 40, 60) 2px 4px 6px, rgb(40, 80, 120) 4px 8px 12px] from add [rgb(100, 100, 100) 10px 20px 30px, rgb(200, 200, 200) 20px 40px 60px] to replace [rgb(200, 200, 200) 20px 40px 60px] at (1) should be [rgb(200, 200, 200) 20px 40px 60px]: FAIL (Safari: FAIL)
Compositing: property <text-shadow> underlying [rgb(10, 20, 30) 1px 2px 3px, rgb(20, 40, 60) 2px 4px 6px] from replace [rgb(100, 100, 100) 10px 20px 30px] to add [rgb(200, 200, 200) 20px 40px 60px] at (0) should be [rgb(100, 100, 100) 10px 20px 30px]: FAIL (Safari: PASS)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1115d18d3541 [wpt PR 21342] - Avoid dereferencing a null pointer in list_interpolation_function, a=testonly https://hg.mozilla.org/integration/autoland/rev/bb9327878608 [wpt PR 21342] - Update wpt metadata, a=testonly
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1115d18d3541
https://hg.mozilla.org/mozilla-central/rev/bb9327878608
Description
•