1610859 - Crash in [@ mozilla::gfx::AdjustedPattern::operator mozilla::gfx::Pattern*]

Status: RESOLVED DUPLICATE of bug 1604800

(Core :: Graphics, defect, P1)

Description

[Bob Owen (:bobowen)]

Bug 1604800 was fixed on Beta (Fx73) by backing out Bug 1604180 and Bug 1598582 in Beta.

This is to fix it on Nightly (Fx74).

+++ This bug was initially created as a clone of Bug #1604800 +++

This bug is for crash report bp-73596e27-d2c3-4bf6-b649-6e1e80191214.

Seen while looking at nightly crash stats - crashes started in 20191213094653: https://bit.ly/2rYOmxp

Possible regression range based on Build ID: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=192e0e33eb597e8d923eb89f6d49bf42654e9d11&tochange=f09f24f2b545919ab0db4bd352c276779c58bcc6

Top 10 frames of crashing thread:

0 XUL mozilla::gfx::AdjustedPattern::operator mozilla::gfx::Pattern* gfx/2d/DrawTargetWrapAndRecord.cpp:239
1 XUL mozilla::gfx::DrawTargetWrapAndRecord::FillRect gfx/2d/DrawTargetWrapAndRecord.cpp:309
2 XUL gfxSurfaceDrawable::DrawInternal gfx/thebes/gfxDrawable.cpp
3 XUL gfxSurfaceDrawable::Draw gfx/thebes/gfxDrawable.cpp:64
4 XUL gfxUtils::DrawPixelSnapped gfx/thebes/gfxUtils.cpp:562
5 XUL mozilla::image::RasterImage::DrawInternal image/RasterImage.cpp:1380
6 XUL mozilla::image::RasterImage::Draw image/RasterImage.cpp:1442
7 XUL DrawImageInternal layout/base/nsLayoutUtils.cpp:6872
8 XUL nsLayoutUtils::DrawSingleImage layout/base/nsLayoutUtils.cpp:6957
9 XUL nsImageFrame::PaintImage layout/generic/nsImageFrame.cpp:2010

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Unless we're planning to land the backout from bug 1604800 on m-c for 74+, I think we can track the remaining work there still.

Comment 2

[Bob Owen (:bobowen)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #1)

Unless we're planning to land the backout from bug 1604800 on m-c for 74+, I think we can track the remaining work there still.

Whatever is easiest, I thought given that we took an action on 1604800 a new bug might be better.
I don't think we need to back out on 74, should have a better fix.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Let's just keep tracking it there. I've updated the Fx73 status so it'll at least be off the radar for that release at this point.