Closed Bug 1610885 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 21349 - Move IsFixedBlockSizeIndefinite into AreSizeConstraintsEqual.

Categories

(Core :: Layout: Flexbox, task, P4)

task

Tracking

()

RESOLVED INVALID

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21349 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21349
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

Move IsFixedBlockSizeIndefinite into AreSizeConstraintsEqual.

In https://chromium-review.googlesource.com/c/chromium/src/+/1966385
we move IsFixedBlockSizeIndefinite out of MaySkipLayout and into the
caching layer.

This wasn't paired with moving this bit into AreSizeConstraintsEqual.

This caused us to skip a layout, when we couldn't. :(

Bug: 1043071
Change-Id: Idbb68e136efe21b77394466a16a7ec3b06abe06d
Reviewed-on: https://chromium-review.googlesource.com/2015101
WPT-Export-Revision: f55c2c4a74e850235b25469b9f396ae7884201f4

Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.