Closed Bug 1610918 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21351 - CookieStore: Fix Flaky WPT Test for getSubscriptions

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox74 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21351 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21351
Details from upstream follow.

Ayu Ishii <ayui@chromium.org> wrote:

CookieStore: Fix Flaky WPT Test for getSubscriptions

This test fails because the cleanup to "unsubscribe" cookies would
occur after the registration has already been unregistered for
non-workers. This change removes the cleanup to "unsubscribe" and
just relies on "unregister" for cleanup.

The flaky failures can be reproduced locally using the following gn args
and commandline. (Googlers: http://screen/E7px76cVS2E)

gn args:
dcheck_always_on = true
ffmpeg_branding = "Chrome"
is_component_build = false
is_debug = false
mac_deterministic_build = true
proprietary_codecs = true
symbol_level = 1
use_goma = true

command: python third_party/blink/tools/run_web_tests.py -t LinuxTest third_party/blink/web_tests/external/wpt/cookie-store/cookieStoreManager_getSubscriptions_multiple.tentative.https.any.js --gtest_repeat=20

Bug: 1029713
Change-Id: Ifa766b974bddfcc6ee43e60be0766c1cb80cb742

Reviewed-on: https://chromium-review.googlesource.com/2014100
WPT-Export-Revision: eb7f685c6b29870115b4dad42db9c9ffff24fde2

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 2
FAIL: 2

Chrome

OK : 2
PASS: 2

Safari

OK : 2
FAIL: 2

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/cookie-store/cookieStoreManager_getSubscriptions_multiple.tentative.https.any.serviceworker.html
getSubscriptions returns a subscription passed to subscribe: FAIL (Chrome: PASS, Safari: FAIL)
/cookie-store/cookieStoreManager_getSubscriptions_multiple.tentative.https.any.html
getSubscriptions returns a subscription passed to subscribe: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/409fdb69ccdf
[wpt PR 21351] - CookieStore: Fix Flaky WPT Test for getSubscriptions, a=testonly

https://hg.mozilla.org/mozilla-central/rev/409fdb69ccdf

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.