1610944 - configure/test_toolchain_configure.py and configure/test_toolchain_helpers.py support Python 3

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Comment 1

[Ricky Stewart]

Attachment: Bug 1610944 - configure/test_toolchain_configure.py and configure/test_toolchain_helpers.py support Python 3

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c2048122a9f
configure/test_toolchain_configure.py and configure/test_toolchain_helpers.py support Python 3 r=firefox-build-system-reviewers,mshal

Comment 3

[Cosmin Sabou [:CosminS]]

Backed out changeset 7c2048122a9f (Bug 1610944) for causing L10n bustages.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=7c2048122a9fef3c5b4ccb6a7c5f0191aa1f2b77&selectedJob=286102267&searchStr=Linux%2Cx64%2Cshippable%2Copt%2Cl10n-linux64-shippable%2Fopt%2C%28L10n%29

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=286102267&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/935b8a2cb0a524c2d6851c029c3ce235ee9d7564

[task 2020-01-23T05:16:02.707Z] 05:16:02 WARNING - /builds/worker/workspace/build/src/python/mozbuild/mozbuild/preprocessor.py:748: UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal
[task 2020-01-23T05:16:02.707Z] 05:16:02 INFO - if aLine == '\n':
[task 2020-01-23T05:16:02.707Z] 05:16:02 ERROR - Traceback (most recent call last):
[task 2020-01-23T05:16:02.708Z] 05:16:02 INFO - File "/usr/lib/python2.7/runpy.py", line 162, in _run_module_as_main
[task 2020-01-23T05:16:02.708Z] 05:16:02 INFO - "main", fname, loader, pkg_name)
[task 2020-01-23T05:16:02.708Z] 05:16:02 INFO - File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
[task 2020-01-23T05:16:02.708Z] 05:16:02 INFO - exec code in run_globals
[task 2020-01-23T05:16:02.708Z] 05:16:02 INFO - File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/action/file_generate.py", line 124, in <module>
[task 2020-01-23T05:16:02.708Z] 05:16:02 INFO - sys.exit(main(sys.argv[1:]))
[task 2020-01-23T05:16:02.708Z] 05:16:02 INFO - File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/action/file_generate.py", line 72, in main
[task 2020-01-23T05:16:02.708Z] 05:16:02 INFO - ret = module.dict[method](output, *args.additional_arguments, **kwargs)
[task 2020-01-23T05:16:02.709Z] 05:16:02 INFO - File "/builds/worker/workspace/build/src/browser/locales/generate_bookmarks.py", line 40, in main
[task 2020-01-23T05:16:02.709Z] 05:16:02 INFO - output=output)
[task 2020-01-23T05:16:02.709Z] 05:16:02 INFO - File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/preprocessor.py", line 854, in preprocess
[task 2020-01-23T05:16:02.709Z] 05:16:02 INFO - pp.processFile(input=input, output=output)
[task 2020-01-23T05:16:02.709Z] 05:16:02 INFO - File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/preprocessor.py", line 420, in processFile
[task 2020-01-23T05:16:02.709Z] 05:16:02 INFO - self.do_include(input, False)
[task 2020-01-23T05:16:02.709Z] 05:16:02 INFO - File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/preprocessor.py", line 829, in do_include
[task 2020-01-23T05:16:02.709Z] 05:16:02 INFO - self.handleLine(l)
[task 2020-01-23T05:16:02.709Z] 05:16:02 INFO - File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/preprocessor.py", line 589, in handleLine
[task 2020-01-23T05:16:02.709Z] 05:16:02 INFO - self.write(aLine)
[task 2020-01-23T05:16:02.709Z] 05:16:02 INFO - File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/preprocessor.py", line 468, in write
[task 2020-01-23T05:16:02.709Z] 05:16:02 INFO - filteredLine = self.applyFilters(aLine)
[task 2020-01-23T05:16:02.709Z] 05:16:02 INFO - File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/preprocessor.py", line 443, in applyFilters
[task 2020-01-23T05:16:02.710Z] 05:16:02 INFO - aLine = f1
[task 2020-01-23T05:16:02.710Z] 05:16:02 INFO - File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/preprocessor.py", line 774, in filter_substitution
[task 2020-01-23T05:16:02.710Z] 05:16:02 INFO - return self.varsubst.sub(repl, aLine)
[task 2020-01-23T05:16:02.710Z] 05:16:02 INFO - File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/preprocessor.py", line 770, in repl
[task 2020-01-23T05:16:02.710Z] 05:16:02 INFO - return six.text_type(self.context[varname])
[task 2020-01-23T05:16:02.710Z] 05:16:02 INFO - UnicodeDecodeError: 'ascii' codec can't decode byte 0xd7 in position 0: ordinal not in range(128)
[task 2020-01-23T05:16:02.714Z] 05:16:02 INFO - backend.mk:23: recipe for target '.deps/bookmarks.html.stub' failed
[task 2020-01-23T05:16:02.714Z] 05:16:02 ERROR - make[2]: *** [.deps/bookmarks.html.stub] Error 1
[task 2020-01-23T05:16:02.714Z] 05:16:02 INFO - make[2]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/browser/locales'
[task 2020-01-23T05:16:02.714Z] 05:16:02 INFO - Makefile:64: recipe for target 'libs-he' failed
[task 2020-01-23T05:16:02.714Z] 05:16:02 ERROR - make[1]: *** [libs-he] Error 2
[task 2020-01-23T05:16:02.714Z] 05:16:02 INFO - make[1]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/browser/locales'
[task 2020-01-23T05:16:02.714Z] 05:16:02 INFO - Makefile:106: recipe for target 'installers-he' failed
[task 2020-01-23T05:16:02.714Z] 05:16:02 INFO - make: *** [installers-he] Error 2

Comment 4

[Ricky Stewart]

Attachment: Bug 1610944 - configure/test_toolchain_configure.py and configure/test_toolchain_helpers.py support Python 3

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5b4973be6da
configure/test_toolchain_configure.py and configure/test_toolchain_helpers.py support Python 3 r=firefox-build-system-reviewers,mshal

Comment 6

[Ricky Stewart]

Fixing and re-landing

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/f5b4973be6da

Comment 8

[Natalia Csoregi [:nataliaCs]]

Backed out for nightly bustages

backout: https://hg.mozilla.org/mozilla-central/rev/31ea4358be64862b45aa5e05bc5a98d70b828cec

push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=a170089a8a033b5a2d8bba365656965aebe3a444&searchStr=nightly&group_state=expanded&selectedJob=286326418

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=286325451&repo=mozilla-central&lineNumber=7076

[task 2020-01-24T11:23:42.974Z] 11:23:42 INFO - if aLine == '\n':
[task 2020-01-24T11:23:42.974Z] 11:23:42 ERROR - Traceback (most recent call last):
[task 2020-01-24T11:23:42.974Z] 11:23:42 INFO - File "/usr/lib/python2.7/runpy.py", line 162, in _run_module_as_main
[task 2020-01-24T11:23:42.974Z] 11:23:42 INFO - "main", fname, loader, pkg_name)
[task 2020-01-24T11:23:42.974Z] 11:23:42 INFO - File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
[task 2020-01-24T11:23:42.974Z] 11:23:42 INFO - exec code in run_globals
[task 2020-01-24T11:23:42.974Z] 11:23:42 INFO - File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/action/langpack_manifest.py", line 489, in <module>
[task 2020-01-24T11:23:42.975Z] 11:23:42 INFO - main(sys.argv[1:])
[task 2020-01-24T11:23:42.975Z] 11:23:42 INFO - File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/action/langpack_manifest.py", line 483, in main
[task 2020-01-24T11:23:42.975Z] 11:23:42 INFO - chrome_entries
[task 2020-01-24T11:23:42.975Z] 11:23:42 INFO - File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/action/langpack_manifest.py", line 388, in create_webmanifest
[task 2020-01-24T11:23:42.975Z] 11:23:42 INFO - defines['MOZ_LANGPACK_CONTRIBUTORS'] if 'MOZ_LANGPACK_CONTRIBUTORS' in defines else ""
[task 2020-01-24T11:23:42.975Z] 11:23:42 INFO - File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/action/langpack_manifest.py", line 179, in build_author_string
[task 2020-01-24T11:23:42.975Z] 11:23:42 INFO - contrib = convert_contributors(contributors)
[task 2020-01-24T11:23:42.975Z] 11:23:42 INFO - File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/action/langpack_manifest.py", line 151, in convert_contributors
[task 2020-01-24T11:23:42.975Z] 11:23:42 INFO - str = str.replace('<em:contributor>', '')
[task 2020-01-24T11:23:42.975Z] 11:23:42 INFO - UnicodeDecodeError: 'ascii' codec can't decode byte 0xd8 in position 16: ordinal not in range(128)
[task 2020-01-24T11:23:42.980Z] 11:23:42 INFO - /builds/worker/workspace/build/src/toolkit/locales/l10n.mk:220: recipe for target 'package-langpack-fa' failed
[task 2020-01-24T11:23:42.980Z] 11:23:42 ERROR - make[1]: *** [package-langpack-fa] Error 1
[task 2020-01-24T11:23:42.981Z] 11:23:42 INFO - make[1]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/browser/locales'
[task 2020-01-24T11:23:42.981Z] 11:23:42 INFO - Makefile:106: recipe for target 'installers-fa' failed
[task 2020-01-24T11:23:42.981Z] 11:23:42 INFO - make: *** [installers-fa] Error 2
[task 2020-01-24T11:23:42.981Z] 11:23:42 ERROR - Return code: 2
[task 2020-01-24T11:23:42.981Z] 11:23:42 ERROR - make installers-fa failed
[task 2020-01-24T11:23:42.981Z] 11:23:42 ERROR - failure: repack_locale(fa)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a010069572f
configure/test_toolchain_configure.py and configure/test_toolchain_helpers.py support Python 3 r=firefox-build-system-reviewers,mshal CLOSED TREE

Comment 10

[Ricky Stewart]

This does indeed look like something that comes from bug 1611006. Looks like we've re-landed the patch, so I assume we're good here.

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/4a010069572f