Closed Bug 1610955 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21357 - Order animations of same class by tree-order of their owning elements

Categories

(Core :: CSS Transitions and Animations, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21357 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21357
Details from upstream follow.

haozhe <haozhes@chromium.org> wrote:

Order animations of same class by tree-order of their owning elements

Currently, getAnimation sort the result by animation class and creation
time.

Sort composite order for animations of the same animation class by tree
order of their owning element according to spec.
(https://drafts.csswg.org/web-animations/#dom-document-getanimations).

This patch align the implementation with the spec.

Bug: 993365

Change-Id: I8478b2985c0ab473db33c176fc69516ea0222ee1
Reviewed-on: https://chromium-review.googlesource.com/2008325
WPT-Export-Revision: f3ceb89c82825957611e3c3ed0b197cd81fb0c1b

Component: web-platform-tests → CSS Transitions and Animations
Product: Testing → Core
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 22 subtests

Status Summary

Firefox

OK : 2
PASS: 34
FAIL: 3

Chrome

OK : 2
PASS: 28
FAIL: 9

Safari

OK : 2
PASS: 30
FAIL: 7

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-animations/Document-getAnimations.tentative.html
CSS Animations targetting (pseudo-)elements should have correct order after sorting: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-animations/Element-getAnimations.tentative.html
{ subtree: true } on a leaf element returns the element's animations and its pseudo-elements' animations: FAIL (Chrome: PASS, Safari: FAIL)
{ subtree: true } on an element with a child returns animations from the element, its pseudo-elements, its child and its child pseudo-elements: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/872c499d814c
[wpt PR 21357] - Order animations of same class by tree-order of their owning elements, a=testonly
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.