Closed Bug 1610971 Opened 4 years ago Closed 4 years ago

Remove all TabGroup assertions

Categories

(Core :: DOM: Core & HTML, task, P2)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1620594
Project Flags:
Fission Milestone M5

People

(Reporter: mccr8, Assigned: farre)

References

(Blocks 1 open bug)

Details

There's a check for this pref in an assertion nsGlobalWindowOuter::TabGroupOuter(). From the comment, it sounds like this assertion involves tab groups and it won't hold with Fission. It sounds like bug 1561715 will eventually make tab groups go away, but until then it feels like the assertion could be changed to check useRemoteSubframes on the relevant docshell. The issue is that a Fission window can be opened when the Fission pref is disabled, and vice versa.

Nika and kmag recommend we just remove all TabGroup assertions. TabGroups are very broken so assertions are not helpful and we wouldn't fix them.

Fission Milestone: --- → M5
Depends on: 1561715
Priority: -- → P2
Summary: nsGlobalWindowOuter::TabGroupOuter() assertion shouldn't call StaticPrefs::fission_autostart() → Remove all TabGroup assertions
Blocks: 1561715
No longer depends on: 1561715

Assigning to farre since he is removing TabGroups. These assertions will either get removed when he removes all TabGroups code (in bug 1561715) or he can remove just the assertions sooner in this bug.

Assignee: nobody → afarre

The patch for bug 1620594 is up, and that does indeed remove all TabGroup-related assertions.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.