1610974 - error about designated initializer in LookAndFeelInt

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[(Away)]

Using the upcoming clang version 10, and --enable-warning-as-errors like automation, the build fails with the following error:

0:13.64 widget/nsXPLookAndFeel.cpp(1103,22): error: mixture of designated and non-designated initializers in the same initializer list is a C99 extension [-Werror,-Wc99-designator]
 0:13.64       LookAndFeelInt{.id = eIntID_PrefersReducedMotion, {.value = value}});
 0:13.64                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 0:13.64 widget/nsXPLookAndFeel.cpp(1103,57): note: first non-designated initializer is here
 0:13.64       LookAndFeelInt{.id = eIntID_PrefersReducedMotion, {.value = value}});
 0:13.64                                                         ^~~~~~~~~~~~~~~~

It looks like clang is not so happy about the second member being an anonymous union, so we can't name it directly.

:hiro, would it be possible to write this initialization in a different way? Thanks!

Comment 1

[Hiroyuki Ikezoe (:hiro)]

I actually wrote a different way but it was complained by a GCC warning such as "uninitialized blah blah blah". That's said, colorValue in the union in question should have been dropped in bug 1606503. We just need to drop nscolor colorValue and drop the union.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1610974 - Drop colorValue in LookAndFeelInt. r?#geckoview-reviewers

It should have been dropped in bug 1606503, I did foget it.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d25ba0ac108
Drop colorValue in LookAndFeelInt. r=geckoview-reviewers,snorp

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/0d25ba0ac108

Comment 5

[(Away)]

The patch actually introduced more instances of mixture of designated and non-designated initializers...

Comment 6

[(Away)]

Attachment: Use designated initializers consistently in LookAndFeelInt

To avoid a clang-10 failure with error: mixture of designated and non-designated initializers in the same initializer list is a C99 extension [-Werror,-Wc99-designator]

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94cf2aa1620b
Use designated initializers consistently in LookAndFeelInt r=hiro

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/94cf2aa1620b