1611046 - Add ServiceWorker shutdown progress tracking

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, enhancement, P2)

Description

[Perry Jiang [:perry] [no longer employee, use ni?]]

ServiceWorkerShutdownBlocker only knows about the number of pending shutdowns but can't give any meaningful information as to what the progress of each shutdown is if there's an AsyncShutdown timeout. There's 6 "stages":

• Parent process main thread
• Parent process IPDL background thread
• Content process worker launcher thread
• Content process main thread
• Content process DOM worker thread
• Shutdown finished

Comment 1

[Perry Jiang [:perry] [no longer employee, use ni?]]

Attachment: Bug 1611046 - add ServiceWorker shutdown progress tracking r?#dom-workers-and-storage

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a59d382a7950
add ServiceWorker shutdown progress tracking r=dom-workers-and-storage-reviewers,asuth

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/a59d382a7950

Comment 4

[Narcis Beleuzu [:NarcisB]]

Backed out for bustages on nsCodeCoverage.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/3c25ab24bcda1aba845a0266071741a3b17e908d
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=286592327&repo=mozilla-central&lineNumber=44364

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/3c25ab24bcda

Comment 6

[Perry Jiang [:perry] [no longer employee, use ni?]]

Attachment: Bug 1611046 - avoid using namespace declaration r?#dom-workers-and-storage

In particular this avoids unqualified name lookup ambiguity between
::Request and mozilla::dom::Request (imported into the global namespace by
using namespace mozilla::dom).

Depends on D60791

Comment 7

[Perry Jiang [:perry] [no longer employee, use ni?]]

Waiting on patch to fix code coverage build breakage.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21e6f8a6b086
add ServiceWorker shutdown progress tracking r=dom-workers-and-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/8f299cada000
avoid using namespace declaration r=dom-workers-and-storage-reviewers,sg

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/21e6f8a6b086
https://hg.mozilla.org/mozilla-central/rev/8f299cada000