1611057 - [wpt-sync] Sync PR 21365 - SharedWorker: Fix the wrong WPT undefined-arguments.html

Status: RESOLVED FIXED

(Core :: DOM: Workers, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 21365 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21365
Details from upstream follow.

Eriko Kurimoto <[e-mail]> wrote:

SharedWorker: Fix the wrong WPT undefined-arguments.html

The worker's name must be |''| in this test.

According to the spec, the default value of WorkerOptions (which is the
second argument of SharedWorker) is set as follows:
dictionary WorkerOptions {
WorkerType type = "classic";
RequestCredentials credentials = "same-origin";
DOMString name = "";
};

spec:https://html.spec.whatwg.org/multipage/workers.html#workeroptions
Here, name property is set to an empty string.
Therefore, the worker's name must be an empty string when the second
argument is |undefined|.
Change-Id: I5bc9c5afcf76beae1e3924661b2ea65fad5efe1d
Reviewed-on: https://chromium-review.googlesource.com/2015911
WPT-Export-Revision: ec33ee59a38f805c237458a1f8c7e0f680ef6114

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=2af4c431f54071def08c3c62024e81a1bc4800d4

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 42 tests

Status Summary

Firefox

OK : 1
PASS: 1[GitHub] 42[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]

Chrome

OK : 1
PASS: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5e87808795b
[wpt PR 21365] - SharedWorker: Fix the wrong WPT undefined-arguments.html, a=testonly
https://hg.mozilla.org/integration/autoland/rev/82bfdad6c9c6
[wpt PR 21365] - Update wpt metadata, a=testonly

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/e5e87808795b
https://hg.mozilla.org/mozilla-central/rev/82bfdad6c9c6