1611110 - [Raptor] Do not check if runnier is started in dektop run_test_teardown

Status: RESOLVED FIXED

(Testing :: Raptor, defect)

Description

[Florin Strugariu [:Bebe]]

https://searchfox.org/mozilla-central/source/testing/raptor/raptor/webextension/desktop.py#186

self.runner.is_running() is raising RunnerNotStartedError if the runner was not started during run_test_teardown
https://searchfox.org/mozilla-central/source/testing/mozbase/mozrunner/mozrunner/base/runner.py#87

and self.runner.stop() already treats this exception when trying to stop the process:
https://searchfox.org/mozilla-central/source/testing/mozbase/mozrunner/mozrunner/base/runner.py#173

Let's remove the check self.runner.is_running()

Error trace:

[task 2020-01-16T19:33:57.957Z] 19:33:57    ERROR -  Traceback (most recent call last):
[task 2020-01-16T19:33:57.957Z] 19:33:57     INFO -    File "C:\Users\task_1579197564\build\tests\raptor\raptor\raptor.py", line 1338, in <module>
[task 2020-01-16T19:33:57.957Z] 19:33:57     INFO -      main()
[task 2020-01-16T19:33:57.957Z] 19:33:57     INFO -    File "C:\Users\task_1579197564\build\tests\raptor\raptor\raptor.py", line 1296, in main
[task 2020-01-16T19:33:57.957Z] 19:33:57     INFO -      success = raptor.run_tests(raptor_test_list, raptor_test_names)
[task 2020-01-16T19:33:57.958Z] 19:33:57     INFO -    File "C:\Users\task_1579197564\build\tests\raptor\raptor\perftest.py", line 253, in run_tests
[task 2020-01-16T19:33:57.958Z] 19:33:57     INFO -      self.run_test_teardown(test)
[task 2020-01-16T19:33:57.958Z] 19:33:57     INFO -    File "C:\Users\task_1579197564\build\tests\raptor\raptor\raptor.py", line 783, in run_test_teardown
[task 2020-01-16T19:33:57.958Z] 19:33:57     INFO -      if self.runner.is_running():
[task 2020-01-16T19:33:57.958Z] 19:33:57     INFO -    File "C:\Users\task_1579197564\build\venv\lib\site-packages\mozrunner\base\runner.py", line 171, in is_running
[task 2020-01-16T19:33:57.958Z] 19:33:57     INFO -      return self.returncode is None
[task 2020-01-16T19:33:57.959Z] 19:33:57     INFO -    File "C:\Users\task_1579197564\build\venv\lib\site-packages\mozrunner\base\runner.py", line 87, in returncode
[task 2020-01-16T19:33:57.959Z] 19:33:57     INFO -      raise RunnerNotStartedError("returncode accessed before runner started")

Comment 1

[Florin Strugariu [:Bebe]]

Attachment: Bug 1611110 - [Raptor] Do not check if runnier is started in dektop run_test_teardown

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6bc8bf1d6a10
[Raptor] Do not check if runnier is started in dektop run_test_teardown r=perftest-reviewers,tarek,AlexandruIonescu

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/6bc8bf1d6a10