1611111 - glean_parser breaks Swift codegen due to field order of metrics

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, defect, P1)

Description

[Jan-Erik Rediger [:janerik]]

Latest updates to the glean_parser causes the Swift code generation to produce invalid code.

In Swift the field order for the initializer is strict, so it needs to be the same in the definition and in code calling it.

Correct:

            category: "glean.baseline",
            name: "duration",
            sendInPings: ["baseline"],
            lifetime: .ping,
            disabled: false,
            timeUnit: .second

Currently generated by glean_parser 1.16.0:

            category: "glean.baseline",
            disabled: false,
            lifetime: .ping,
            name: "duration",
            sendInPings: ["baseline"],
            timeUnit: .second

Comment 1

[Jan-Erik Rediger [:janerik]]

Attachment: GitHub Pull Request