1611179 - Firefox Home - First Highlights tile does not immediately reflect correct bookmark name

Status: NEW

(Firefox :: New Tab Page, defect, P3)

Description

[bc_bugzilla]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:72.0) Gecko/20100101 Firefox/72.0

Steps to reproduce:

1. Download the latest FF nightly. (No existing user data or bookmarks.)

2. Visit Wikipedia.org or any other site.

3. Bookmark the page via the star icon in the address bar. Give the bookmark a new name other than the title of the page, such as "WikipediaCustomName".

4. Navigate to Firefox Home via the home button and scroll to the Highlights section.

Actual results:

The name on the first Highlights tile is the default name, not the new name (e.g. "Wikipedia", not "WikipediaCustomName").

This only affects the first tile. Repeating the process with another website moves the first bookmark (Wikipedia) to a second tile, and that name updates to the correct name. However, the new first tile will have an incorrect name.

Refreshing the page has no effect. However, on restarting Firefox, the first tile's name updates to the correct name.

I'm not sure how this issue relates to "non-bookmark" Highlights tiles such as those for frequently visited sites.

Expected results:

As for all such tiles, the name on the first Highlights bookmark tile should always be the current bookmark name, not the default name.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

I can trace this issue as far back as Firefox 58, but mozregression doesn't help much more than that. The pushlog is a bit on the long side, but bug 1410541 stands out as a possible cause.

@Ed, is that the bug where we introduced prerendering/preloading?

Comment 3

[Ed Lee :Mardak]

I believe the bookmark creation happens with the original page's title, and custom title is set later even from the initial bookmark creation. Bug 1392267 avoided running code from onItemChanged, which I believe would detect the title change.

The reason why bookmarking a second page causes the first bookmark to display the correct title is the original bookmark is now "old" and fetched directly from places instead of relying on a local cache.