Closed Bug 1611223 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21382 - Remove assert_throws use in custom elements tests

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21382 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21382
Details from upstream follow.

Boris Zbarsky <bzbarsky@mit.edu> wrote:

Remove assert_throws use in custom elements tests

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 45 tests

Status Summary

Firefox

OK : 4
PASS: 177[GitHub] 218[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL: 12

Chrome

OK : 4
PASS: 178
FAIL: 11

Safari

OK : 4
PASS: 156
FAIL: 33

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/custom-elements/Document-createElement.html
document.createElement must report a NotSupportedError when the element is inserted into a the document of an iframe during construction: FAIL
document.createElement must not report a NotSupportedError when the element is adopted back from a the document of an iframe during construction: FAIL
document.createElement must report a NotSupportedError when the element is adopted into a the document of an iframe during construction: FAIL
/custom-elements/CustomElementRegistry.html
customElements.define must get callbacks of the constructor prototype: FAIL
customElements.define must rethrow an exception thrown while converting a callback value to Function callback type: FAIL
customElements.define must rethrow an exception thrown while getting callbacks on the constructor prototype: FAIL

New Tests That Don't Pass

/custom-elements/Document-createElement.html
document.createElement must report a NotSupportedError when the element is inserted into a the document of an iframe during construction: FAIL (Chrome: PASS, Safari: PASS)
document.createElement must not report a NotSupportedError when the element is adopted back from a the document of an iframe during construction: FAIL (Chrome: PASS, Safari: PASS)
document.createElement must report a NotSupportedError when the element is adopted into a the document of an iframe during construction: FAIL (Chrome: PASS, Safari: PASS)
/custom-elements/CustomElementRegistry.html
customElements.define must get "observedAttributes" property on the constructor prototype when "attributeChangedCallback" is present: FAIL (Chrome: PASS, Safari: FAIL)
customElements.define must rethrow an exception thrown while getting formAssociated on the constructor prototype: FAIL (Chrome: PASS, Safari: FAIL)
customElements.define must rethrow an exception thrown while getting additional formAssociated callbacks on the constructor prototype: FAIL (Chrome: PASS, Safari: FAIL)
customElements.define must get callbacks of the constructor prototype: FAIL (Chrome: PASS, Safari: PASS)
customElements.define must rethrow an exception thrown while converting a callback value to Function callback type: FAIL (Chrome: PASS, Safari: PASS)
customElements.define must get four additional callbacks on the prototype if formAssociated is converted to true: FAIL (Chrome: PASS, Safari: FAIL)
customElements.define must rethrow an exception thrown while getting callbacks on the constructor prototype: FAIL (Chrome: PASS, Safari: PASS)
customElements.define must get "prototype", "disabledFeatures", and "formAssociated" property of the constructor: FAIL (Chrome: PASS, Safari: FAIL)
customElements.define must not throw when defining another custom element in a different global object during Get(constructor, "prototype"): FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/604a25206774
[wpt PR 21382] - Remove assert_throws use in custom elements tests, a=testonly

https://hg.mozilla.org/mozilla-central/rev/604a25206774

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.