Closed Bug 1611225 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 21383 - Remove assert_throws use in payment request tests

Categories

(Core :: DOM: Web Payments, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21383 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21383
Details from upstream follow.

Boris Zbarsky <bzbarsky@mit.edu> wrote:

Remove assert_throws use in payment request tests

Component: web-platform-tests → DOM: Web Payments
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 43 tests

Status Summary

Firefox

OK : 2
PASS: 41
FAIL: 19

Chrome

OK : 2
PASS: 19

Safari

OK : 2
PASS: 19

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/payment-request/payment-request-ctor-currency-code-checks.https.html
Check and canonicalize invalid details.total.amount and rethrow any exceptions.: FAIL
Check and canonicalize invalid modifiers[n].total amount and rethrow RangeError.: FAIL
Check and canonicalize invalid details.displayItems amount and rethrow RangeError.: FAIL
Check and canonicalize valid modifiers[n].total amount.: FAIL
Check and canonicalize valid details.shippingOptions amount.: FAIL
Check and canonicalize valid details.total.amount: FAIL
Check and canonicalize valid details.displayItems amount: FAIL
Check and canonicalize invalid modifiers[n].additionaDisplayItem amount and rethrow RangeError.: FAIL
Check and canonicalize valid modifiers[n].additionaDisplayItem amount.: FAIL
Check and canonicalize invalid details.shippingOptions amount and rethrow RangeError.: FAIL
/payment-request/historical.https.html
regionCode in PaymentAddress: FAIL
paymentRequestID in PaymentResponse: FAIL
supportedMethods must not support sequence<DOMString>: FAIL
paymentRequestId in PaymentResponse: FAIL
paymentRequestId in PaymentRequest: FAIL
languageCode in PaymentAddress: FAIL
careOf in PaymentAddress: FAIL
paymentRequestID in PaymentRequest: FAIL
totalAmount in PaymentResponse: FAIL

New Tests That Don't Pass

/payment-request/payment-request-ctor-currency-code-checks.https.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
Check and canonicalize invalid details.total.amount and rethrow any exceptions.: FAIL (Chrome: PASS, Safari: PASS)
Check and canonicalize invalid modifiers[n].total amount and rethrow RangeError.: FAIL (Chrome: PASS, Safari: PASS)
Check and canonicalize invalid details.displayItems amount and rethrow RangeError.: FAIL (Chrome: PASS, Safari: PASS)
Check and canonicalize valid modifiers[n].total amount.: FAIL (Chrome: PASS, Safari: PASS)
Check and canonicalize valid details.shippingOptions amount.: FAIL (Chrome: PASS, Safari: PASS)
Check and canonicalize valid details.total.amount: FAIL (Chrome: PASS, Safari: PASS)
Check and canonicalize valid details.displayItems amount: FAIL (Chrome: PASS, Safari: PASS)
Check and canonicalize invalid modifiers[n].additionaDisplayItem amount and rethrow RangeError.: FAIL (Chrome: PASS, Safari: PASS)
Check and canonicalize valid modifiers[n].additionaDisplayItem amount.: FAIL (Chrome: PASS, Safari: PASS)
Check and canonicalize invalid details.shippingOptions amount and rethrow RangeError.: FAIL (Chrome: PASS, Safari: PASS)
/payment-request/historical.https.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
regionCode in PaymentAddress: FAIL (Chrome: PASS, Safari: PASS)
paymentRequestID in PaymentResponse: FAIL (Chrome: PASS, Safari: PASS)
supportedMethods must not support sequence<DOMString>: FAIL (Chrome: PASS, Safari: PASS)
paymentRequestId in PaymentResponse: FAIL (Chrome: PASS, Safari: PASS)
paymentRequestId in PaymentRequest: FAIL (Chrome: PASS, Safari: PASS)
languageCode in PaymentAddress: FAIL (Chrome: PASS, Safari: PASS)
careOf in PaymentAddress: FAIL (Chrome: PASS, Safari: PASS)
paymentRequestID in PaymentRequest: FAIL (Chrome: PASS, Safari: PASS)
totalAmount in PaymentResponse: FAIL (Chrome: PASS, Safari: PASS)

Tests Disabled in Gecko Infrastructure

/payment-request/payment-request-ctor-currency-code-checks.https.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
/payment-request/historical.https.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/553b361c89c5
[wpt PR 21383] - Remove assert_throws use in payment request tests, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.