Closed Bug 1611295 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21398 - [css-layout-api] Baselines

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21398 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21398
Details from upstream follow.

Alison Maher <almaher@microsoft.com> wrote:

[css-layout-api] Baselines

This change adds support for the CSS Layout API Alignment, both in
retrieving child baselines and in setting parent baselines.
https://drafts.css-houdini.org/css-layout-api/#interaction-alignment

Due to recent changes, fragments produce only one baseline.
https://chromium-review.googlesource.com/c/chromium/src/+/1988376
As a result, custom LayoutFragments will always produce the
first-line baseline.

Bug: 726125
Change-Id: Ia92eddcd8cf6d7f1cc58c767cc71a199b0b7418e
Reviewed-on: https://chromium-review.googlesource.com/2015723
WPT-Export-Revision: 5c34ef8331a1287e32d094434810c23e7e34d3ae

Component: web-platform-tests → Layout
Product: Testing → Core
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests

Status Summary

Firefox

FAIL: 4

Chrome

PASS: 2
FAIL: 2

Safari

FAIL: 4

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-layout-api/baseline/no-baseline.https.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-layout-api/baseline/flex-baseline.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/baseline/child-baseline.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-layout-api/baseline/orthogonal-baseline.https.html: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/92625838600b
[wpt PR 21398] - [css-layout-api] Baselines, a=testonly
https://hg.mozilla.org/integration/autoland/rev/3d91cca5090e
[wpt PR 21398] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/92625838600b
https://hg.mozilla.org/mozilla-central/rev/3d91cca5090e

Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.