1611301 - Ensure that Node is v10+ in `mach browsertime`

Status: RESOLVED INVALID

(Testing :: Raptor, defect, P1)

Description

[Nick Alexander :nalexander [he/him]]

New (post 4.0) browsertime versions require Node >= 10.13. Sadly, this means that the "out of the box" toolchain Node installed during mach bootstrap isn't enough. It's hard to move the world forward so, following this reasoning, this ticket tracks ensuring that the Node version used in mach browsertime is 10+ for local invocations.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1611301 - Ensure that Node is v10+ in `mach browsertime`. r?tarek

New (post 4.0) browsertime versions require Node >= 10.13. Sadly, this
means that the "out of the box" toolchain Node installed during mach
bootstrap isn't enough (currently it's only 8). Bug 1547823 tracks
moving the build and all tooling forward but that will likely take
more than a month. Therefore, we're going to try to move automation
forward. This handles local mach browsertime invocations as best we
can, by version checking and printing terse instructions for fetching
a Node 10 binary.

Comment 2

[Nick Alexander :nalexander [he/him]]

And... I now realize that we also need a Node >= 10.13 in Raptor itself. I think that means that I should push the more verbose logging into the find_node_executable() function so that we don't have to duplicate it in the tool itself. A first review pass would still be helpful, Tarek, but more changes to come.

Comment 3

[Nick Alexander :nalexander [he/him]]

(In reply to Nick Alexander :nalexander [he/him] from comment #2)

And... I now realize that we also need a Node >= 10.13 in Raptor itself. I think that means that I should push the more verbose logging into the find_node_executable() function so that we don't have to duplicate it in the tool itself. A first review pass would still be helpful, Tarek, but more changes to come.

Aha! Past me helped future me: the code path is the same: https://searchfox.org/mozilla-central/rev/d48b18fa27315206bf68d4dac82bc4e27a3f138e/testing/raptor/mach_commands.py#172.

Comment 4

[Greg Mierzwinski [:sparky]]

Node 10 has landed in tree so we don't need this change now.