Closed Bug 1611417 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 21409 - Rework/update SMIL event tests to better match spec

Categories

(Core :: SVG, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21409 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21409
Details from upstream follow.

Fredrik Söderquist <fs@opera.com> wrote:

Rework/update SMIL event tests to better match spec

This is in preparation for fixing the behavior of SMIL events wrt to
seeking. This also makes these tests pass in Gecko with a single
exception.

svg/animations/begin-event.svg,
svg/animations/end-event.svg,
svg/animations/repeat-event.svg,
svg/animations/onbegin.svg,
svg/animations/onend.svg and
svg/animations/onrepeat.svg

Adjust the seeked-to time so that the beginEvent/endEvent/repeatEvent
is dispatched. Convert from reftests to testharness.js.

svg/animations/repeatn-event-1a.svg,
svg/animations/repeatn-event-1b.svg,
svg/animations/repeatn-event-1c.svg,
svg/animations/repeatn-event-1d.svg and
svg/animations/repeatn-event-1e.svg

'repeatEvent's are not dispatched while seeking, so seek to just before
the relevant repeat and then wait for the event. Convert from reftests
to testharness.js.

svg/animations/repeatn-event-2a.svg

Switch to "stepping through" all the repeat points rather than to the
end directly. Convert from reftest to testharness.js.

wpt/svg/animations/repeatn-remove-add-animation.html

Need to make sure that 'repeatEvent's are actually dispatched, so this
test cannot use smil_async_test() which steps while paused.

Bug: 1039886
Change-Id: I500f5005a29ed22a920dd3835f8070b52d4def7c
Reviewed-on: https://chromium-review.googlesource.com/2017527
WPT-Export-Revision: eb010eb77609cf37d0bda4ee03bbd6d9a31be352

Component: web-platform-tests → SVG
Product: Testing → Core
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/svg/animations/repeatn-remove-add-animation.html
Remove and add an animation element while the animation is repeating: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/55dc41170cd3
[wpt PR 21409] - Rework/update SMIL event tests to better match spec, a=testonly
https://hg.mozilla.org/integration/autoland/rev/4c0f243f8e91
[wpt PR 21409] - Update wpt metadata, a=testonly
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.