1611418 - SourceMapURLService originalPositionFor should return null when sourcemaps are disable via prefs

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

What happened?

During the Bug 1609671 review Julian noticed that SourceMapURLService is only checking the "devtools.source-map.client-service.enabled" preference for its "event-based" API but not for originalPositionFor.

What should have happened?

As Julian pointed out in his review comment, we can either:

• 1/ return null in originalPositionFor if the preference is false (we are already tracking it inside the module via _prefValue)
• 2/ review with @Harald if the option "Enable Source Maps" still makes sense to be exposed or if we should just always enable source maps now

Anything else we should know?

I'm going to attach a patch for the option 1 (and include an additional test case to cover the scenario for the inspect binding, in addition to the one added in Bug 1609671), if instead we are going to remove the pref sooner, this issue can be resolved as "wontfix".

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1611418 - SourceMapURLService originalPositionFor should return null when sourcemaps are disable via prefs. r?jdescottes!

Depends on D60142

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80b669e25635
SourceMapURLService originalPositionFor should return null when sourcemaps are disable via prefs. r=jdescottes

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/80b669e25635