1611454 - Perma late beta browser/base/content/test/webrtc/browser_devices_get_user_media_in_frame.js | uncaught exception - TypeError: notification.options.checkbox is undefined.../PopupNotifications.js when Gecko 74 merges to Beta on 2020-02-10

Status: VERIFIED FIXED

(Core :: WebRTC, defect, P2)

Description

[Arthur Iakab [arthur_iakab]]

[Tracking Requested - why for this release]:
Central as Beta:https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=1560fe31916a342a291920c11f9f2235c229f170&searchStr=browser%2Cchrome&selectedJob=286348850

Failure log https://treeherder.mozilla.org/logviewer.html#?job_id=286348850&repo=try
Part of that log
[task 2020-01-24T14:48:35.519Z] 14:48:35 INFO - Buffered messages logged at 14:48:35
[task 2020-01-24T14:48:35.519Z] 14:48:35 INFO - TEST-PASS | browser/base/content/test/webrtc/browser_devices_get_user_media_in_frame.js | webRTC-shareDevices notification shown -
[task 2020-01-24T14:48:35.520Z] 14:48:35 INFO - TEST-PASS | browser/base/content/test/webrtc/browser_devices_get_user_media_in_frame.js | notification panel open -
[task 2020-01-24T14:48:35.520Z] 14:48:35 INFO - TEST-PASS | browser/base/content/test/webrtc/browser_devices_get_user_media_in_frame.js | notification panel populated -
[task 2020-01-24T14:48:35.521Z] 14:48:35 INFO - TEST-PASS | browser/base/content/test/webrtc/browser_devices_get_user_media_in_frame.js | microphone selector visible -
[task 2020-01-24T14:48:35.522Z] 14:48:35 INFO - TEST-PASS | browser/base/content/test/webrtc/browser_devices_get_user_media_in_frame.js | camera selector visible -
[task 2020-01-24T14:48:35.522Z] 14:48:35 INFO - TEST-PASS | browser/base/content/test/webrtc/browser_devices_get_user_media_in_frame.js | screen selector hidden -
[task 2020-01-24T14:48:35.523Z] 14:48:35 INFO - Buffered messages finished
[task 2020-01-24T14:48:35.525Z] 14:48:35 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/webrtc/browser_devices_get_user_media_in_frame.js | uncaught exception - TypeError: notification.options.checkbox is undefined at _onCheckboxCommand@resource://gre/modules/PopupNotifications.jsm:1757:1
[task 2020-01-24T14:48:35.526Z] 14:48:35 INFO - oncommand@chrome://browser/content/browser.xhtml:1:20
[task 2020-01-24T14:48:35.526Z] 14:48:35 INFO - activateSecondaryAction@chrome://mochitests/content/browser/browser/base/content/test/webrtc/head.js:370:31
[task 2020-01-24T14:48:35.527Z] 14:48:35 INFO - checkStopSharing/<@chrome://mochitests/content/browser/browser/base/content/test/webrtc/browser_devices_get_user_media_in_frame.js:95:32
[task 2020-01-24T14:48:35.527Z] 14:48:35 INFO - promiseMessage@chrome://mochitests/content/browser/browser/base/content/test/webrtc/head.js:305:5
[task 2020-01-24T14:48:35.528Z] 14:48:35 INFO - checkStopSharing@chrome://mochitests/content/browser/browser/base/content/test/webrtc/browser_devices_get_user_media_in_frame.js:94:13
[task 2020-01-24T14:48:35.529Z] 14:48:35 INFO -
[task 2020-01-24T14:48:35.529Z] 14:48:35 INFO - Stack trace:
[task 2020-01-24T14:48:35.530Z] 14:48:35 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:1696
[task 2020-01-24T14:48:35.530Z] 14:48:35 INFO - chrome://mochitests/content/browser/browser/base/content/test/webrtc/head.js:activateSecondaryAction:370
[task 2020-01-24T14:48:35.531Z] 14:48:35 INFO - chrome://mochitests/content/browser/browser/base/content/test/webrtc/browser_devices_get_user_media_in_frame.js:checkStopSharing/<:95
[task 2020-01-24T14:48:35.531Z] 14:48:35 INFO - chrome://mochitests/content/browser/browser/base/content/test/webrtc/head.js:promiseMessage:305
[task 2020-01-24T14:48:35.532Z] 14:48:35 INFO - chrome://mochitests/content/browser/browser/base/content/test/webrtc/browser_devices_get_user_media_in_frame.js:checkStopSharing:94
[task 2020-01-24T14:48:35.532Z] 14:48:35 INFO - GECKO(2527) | JavaScript error: resource://gre/modules/PopupNotifications.jsm, line 1757: TypeError: notification.options.checkbox is undefined
[task 2020-01-24T14:48:35.535Z] 14:48:35 INFO - Console message: [JavaScript Error: "TypeError: notification.options.checkbox is undefined" {file: "resource://gre/modules/PopupNotifications.jsm" line: 1757}]
[task 2020-01-24T14:48:35.536Z] 14:48:35 INFO - _onCheckboxCommand@resource://gre/modules/PopupNotifications.jsm:1757:1
[task 2020-01-24T14:48:35.537Z] 14:48:35 INFO - oncommand@chrome://browser/content/browser.xhtml:1:20
[task 2020-01-24T14:48:35.537Z] 14:48:35 INFO - activateSecondaryAction@chrome://mochitests/content/browser/browser/base/content/test/webrtc/head.js:370:31
[task 2020-01-24T14:48:35.538Z] 14:48:35 INFO - checkStopSharing/<@chrome://mochitests/content/browser/browser/base/content/test/webrtc/browser_devices_get_user_media_in_frame.js:95:32
[task 2020-01-24T14:48:35.540Z] 14:48:35 INFO - promiseMessage@chrome://mochitests/content/browser/browser/base/content/test/webrtc/head.js:305:5
[task 2020-01-24T14:48:35.540Z] 14:48:35 INFO - checkStopSharing@chrome://mochitests/content/browser/browser/base/content/test/webrtc/browser_devices_get_user_media_in_frame.js:94:13

This could be regressed by https://bugzilla.mozilla.org/show_bug.cgi?id=1606265

kendall can you please take a look?

Comment 1

[Kendall]

This doesn't look related to 1606265 to me. Do you have reason to suspect it is? Could it be an issue with the rtc test?

Comment 2

[Cosmin Sabou [:CosminS]]

This fails only on late beta and after reading comment 1 thought maybe Bug 1608584 caused it but looks that's not the culprit either: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&author=aciure%40mozilla.com&fromchange=4f5ed01241e29e2e0ba5549dcf5d04d293445499&searchStr=linux%2Cx64%2Casan%2Cmochitests%2Ctest-linux64-asan%2Fopt-mochitest-browser-chrome-e10s-7%2Cm%28bc7%29&selectedJob=286465574

Central pushlog from the last good central rev to the first bad one is: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a1669b5990974f625d95260c059dcf8f87129a8d&tochange=a4ef54d57737f24d2542187a3d0c627e5d28b24b

The beta-sim after Bug 1609973 https://hg.mozilla.org/mozilla-central/rev/89bd83783b10841d1a3a189900ba07adc59f99c9 got into central has the jobs green on late beta: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&author=malexandru%40mozilla.com&tochange=122d4f38327f6f253b1392309f520525d2cb7849&fromchange=ebae107ff41cb9dd9b4aa92eaae0c5d6a50aa82d&searchStr=linux%2Cx64%2Casan%2Cmochitests%2Ctest-linux64-asan%2Fopt-mochitest-browser-chrome-e10s-7%2Cm%28bc7%29&selectedJob=286123660

Aryx, any ideas which bug could have caused these failures?

Comment 3

[Michael Froman [:mjf]]

Marking this a P2 for now. Jib, is this something that you're familiar with?

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1611454 - browser_devices_get_user_media_in_frame.js: enable dom.security.featurePolicy.enabled and permissions.delegation.enabled. r=mjf

These prefs got disabled for Late Beta and Release in bug 1611454 but the test
uses the feature (access to media devices from frame).

Comment 5

[Intermittent Failures Robot]

9 failures in 4004 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 9

Platform breakdown:

• linux64: 1
• windows10-64: 1
• macosx1014-64-devedition: 1
• macosx1014-64-shippable: 1
• windows7-32-shippable: 1
• windows7-32-devedition: 1
• windows10-64-shippable: 1
• windows10-64-shippable-qr: 1
• windows10-64-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1611454&startday=2020-01-20&endday=2020-01-26&tree=all

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df59b74d33d7
browser_devices_get_user_media_in_frame.js: enable dom.security.featurePolicy.enabled and permissions.delegation.enabled. r=mjf

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/df59b74d33d7

Comment 8

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Thanks Sebastian!

Comment 9

[Natalia Csoregi [:nataliaCs]]

Verified as fixed with the latest beta-sim: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=9d3e16d3e0b94a907ad816513685f8f7d4d63ec7&searchStr=browser-chrome