1611466 - Appending "&test_paths=foo" to the URL will only filter jobs if you do a full reload

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect, P3)

Description

[Armen [:armenzg]]

If you append to the URL "&test_paths=foo" it will not filter the jobs that have executed such test paths. Reloading the URL with "&test_paths=foo" will show it correctly.

Steps to reproduce:

• Load https://treeherder.mozilla.org/#/jobs?repo=mozilla-central
• Append &test_paths=devtools to the URL and press enter

Expected results:

• A lot of jobs are shown that have executed tests with devtools in their path

Actual results:

• No jobs are shown

Work around

• Reload the URL

Comment 1

[Armen [:armenzg]]

Related code:
https://github.com/mozilla/treeherder/pull/5794/files

Comment 2

[Suyash Salampuria]

This is an issue existing with the whole app actually and not with this component. Neither is any request being served on clicking it nor is the state of the component changing. I am looking into the cause of this. Any help will be highly thankful.

Comment 3

[Armen [:armenzg]]

I don't know how to solve this without working on it.

The problem is probably rooted on a disconnect on how we handle URL parameter changes and to trigger changes associated to filtering.

I would first simply look to find out if URL parameter changes by modifying the URL and pressing enter are even noticed. Maybe there's some info on stackoverflow or the react-router documentation.

I hope that helps!

Comment 4

[Suyash Salampuria]

Just checked it now, the issue exists no longer .
Appends &test_paths=foo to https://treeherder.mozilla.org/#/jobs?repo=mozilla-central gives the results we expect

Comment 5

[Armen [:armenzg]]

Thanks for checking!

This was probably a side effect of a bug that I fixed last week:
https://github.com/mozilla/treeherder/commit/013c949c4037c16d91d774394b0995c5353f3a67