Closed Bug 1611498 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21416 - Fix scroll to text WPT flakiness

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox74 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21416 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21416
Details from upstream follow.

Nick Burris <nburris@chromium.org> wrote:

Fix scroll to text WPT flakiness

Since stash.py polls until results are available, the tests can time out
in a single threaded environment if the test page tries to fetch results
before the target page stashes them. This patch moves the polling to
stash.js instead, so that the target page is free to stash results.

Bug: https://github.com/web-platform-tests/wpt/issues/20269
Change-Id: Ia2df8f889596e91207aca92f6ecb290c9f96d201
Reviewed-on: https://chromium-review.googlesource.com/2018099
WPT-Export-Revision: 25238c1cbbaa6f89d9d4208a63eea15c10139552

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 38 subtests

Status Summary

Firefox

OK : 2
PASS: 1
FAIL: 42

Chrome

OK : 2
PASS: 41
FAIL: 2

Safari

OK : 2
PASS: 1
FAIL: 42

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/scroll-to-text-fragment/scroll-to-text-fragment-security.html
Test that a text fragment directive requires a user activation (user_activation=false).: FAIL (Chrome: PASS, Safari: FAIL)
Test that a text fragment directive is not activated within an iframe.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that a text fragment directive requires a user activation (user_activation=true).: FAIL (Chrome: PASS, Safari: FAIL)
Test that a text fragment directive is not activated when there is a window opener (noopener=true).: FAIL (Chrome: PASS, Safari: FAIL)
Test that a text fragment directive is not activated when there is a window opener (noopener=false).: FAIL (Chrome: FAIL, Safari: FAIL)
/scroll-to-text-fragment/scroll-to-text-fragment.html
Test navigation with fragment: Fragment directive with percent encoded syntactical characters "&,-" should match text.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Non-matching text directive with existing element fragment should scroll to element.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Generic fragment directive with existing element fragment should scroll to element.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Exact text with prefix should match text.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Multiple match text directive disambiguated by suffix should match the suffixed text.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Exact text with suffix should match text.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Text directive should match when context terms are separated by node boundaries.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Non-matching text directive with nonexistent element fragment should not match and not scroll.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Non-whole-word exact text with spaces should not match.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Text range with prefix and suffix should match text.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Text directive should not scroll to hidden text.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Multiple match text directive disambiguated by prefix should match the prefixed text.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Text range with no context should match text.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Text range with prefix and nonmatching suffix should not match.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Multiple non-whole-word exact texts should not match.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Multiple text directives and a non-text directive should match text.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Text directive should match text within shadow DOM.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Text range with non-matching startText should not match.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Text directive with invalid syntax (context terms without "-") should not parse as a text directive.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Text directive with existing element fragment should match and scroll into view text.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Multiple match text directive disambiguated by prefix and suffix should match the text with the given context.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Text range with non-matching endText should not match.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Text range with prefix should match text.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Text range with suffix should match text.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Text directive with nonexistent element fragment should match and scroll into view text.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Text range with nonmatching prefix and matching suffix should not match.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Exact text with prefix and suffix should match text.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Fragment directive with all TextMatchChars should match text.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Exact text with percent encoded spaces should match text.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: A non-matching text directive followed by a matching text directive should match and scroll into view the second text directive.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Text directive should not scroll to display none text.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Uppercase TEXT directive should not parse as a text directive.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Multiple matching exact texts should match text.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Fragment directive with percent encoded non-ASCII unicode character should match text.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Exact text with no context should match text.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Text directive should horizontally scroll into view.: FAIL (Chrome: PASS, Safari: FAIL)
Test navigation with fragment: Text directive followed by non-text directive should match text.: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/342c7e395f40
[wpt PR 21416] - Fix scroll to text WPT flakiness, a=testonly

https://hg.mozilla.org/mozilla-central/rev/342c7e395f40

Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.