1611528 - Cleanup compilation data management

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

BytecodeCompiler and ParseInfo have grown into overlapping pieces.

This bug is about merging the two.

(Now that I've seen what it looks like on the other side I strongly prefer it!)

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1611528 - Add include for CheckRecursionLimit r?djvj

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1611528 - Rename ParseInfo to CompilationInfo r?djvj

Depends on D61019

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1611528 - Move Context and options out of BytecodeCompiler and into CompilationInfo r?djvj

Depends on D61020

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1611528 - Move AutoKeepAtoms to CompilationInfo, and make it the only instance r?djvj

Depends on D61021

Comment 5

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1611528 - Remove BytecodeCompiler::scriptSource r?djvj

Depends on D61022

Comment 6

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1611528 - Remove AutoInitializeSourceObject and sourceObjectPtr r?djvj

Depends on D61023

Comment 7

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1611528 - Remove Directives from BytecodeCompiler r?djvj

Depends on D61024

Comment 8

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1611528 - Remove script member from BytecodeCompiler r?djvj

Depends on D61025

Comment 9

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1611528 - Remove BytecodeCompiler::context r?djvj

Depends on D61026

Comment 10

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1611528 - Convert CanLazilyParse to a static function r?djvj

Depends on D61027

Comment 11

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1611528 - Remove BytecodeCompiler::assignSource r?djvj

Depends on D61028

Comment 12

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1611528 - Disconnect a bit of SourceAwareParser r?djvj

Depends on D61029

Comment 13

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1611528 - Thin use of BytecodeCompiler in SourceAwareCompiler r?djvj

Depends on D61030

Comment 14

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1611528 - Remove BytecodeCompiler::emplaceEmitter r?djvj

Depends on D61031

Comment 15

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1611528 - Remove assertSourceCreated r?djvj

Depends on D61032

Comment 16

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1611528 - Use CompilationInfo for handleParseFailure r?djvj

Depends on D61033

Comment 17

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1611528 - Delete GlobalScriptInfo r?djvj

Depends on D61034

Comment 18

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1611528 - Remove EvalScriptInfo r?djvj

Depends on D61035

Comment 19

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1611528 - Remove ModuleInfo r?djvj

Depends on D61036

Comment 20

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1611528 - Remove StandaloneFunctionInfo r?djvj

Depends on D61037

Comment 21

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1611528 - Remove BytecodeCompiler r?djvj

Depends on D61038

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/553c8df1e87f
Add include for CheckRecursionLimit r=djvj
https://hg.mozilla.org/integration/autoland/rev/5e5900f8a83f
Rename ParseInfo to CompilationInfo r=djvj
https://hg.mozilla.org/integration/autoland/rev/6ba5da3138a0
Move Context and options out of BytecodeCompiler and into CompilationInfo r=djvj
https://hg.mozilla.org/integration/autoland/rev/f9ee136e90db
Move AutoKeepAtoms to CompilationInfo, and make it the only instance r=djvj
https://hg.mozilla.org/integration/autoland/rev/21581ff62cd5
Remove BytecodeCompiler::scriptSource r=djvj
https://hg.mozilla.org/integration/autoland/rev/c3b8b8aea242
Remove AutoInitializeSourceObject and sourceObjectPtr r=djvj
https://hg.mozilla.org/integration/autoland/rev/70bf5006862f
Remove Directives from BytecodeCompiler r=djvj
https://hg.mozilla.org/integration/autoland/rev/e74ba3ea5751
Remove script member from BytecodeCompiler r=djvj
https://hg.mozilla.org/integration/autoland/rev/55bd40282d25
Remove BytecodeCompiler::context r=djvj
https://hg.mozilla.org/integration/autoland/rev/d9fa5bd2f4f8
Convert CanLazilyParse to a static function r=djvj
https://hg.mozilla.org/integration/autoland/rev/f20ad70d5a12
Remove BytecodeCompiler::assignSource r=djvj
https://hg.mozilla.org/integration/autoland/rev/1402b4275f5a
Disconnect a bit of SourceAwareParser r=djvj
https://hg.mozilla.org/integration/autoland/rev/c7682a1018f5
Thin use of BytecodeCompiler in SourceAwareCompiler r=djvj
https://hg.mozilla.org/integration/autoland/rev/c289ab3f98ec
Remove BytecodeCompiler::emplaceEmitter r=djvj
https://hg.mozilla.org/integration/autoland/rev/6bdbfb767513
Remove assertSourceCreated r=djvj
https://hg.mozilla.org/integration/autoland/rev/7fc17e3747ca
Use CompilationInfo for handleParseFailure r=djvj
https://hg.mozilla.org/integration/autoland/rev/a803f02ebefe
Delete GlobalScriptInfo r=djvj
https://hg.mozilla.org/integration/autoland/rev/4ed5534078c3
Remove EvalScriptInfo r=djvj
https://hg.mozilla.org/integration/autoland/rev/65ee98c30605
Remove ModuleInfo r=djvj
https://hg.mozilla.org/integration/autoland/rev/0dd7f7a0354b
Remove StandaloneFunctionInfo r=djvj
https://hg.mozilla.org/integration/autoland/rev/cf8eeec663a2
Remove BytecodeCompiler r=djvj

Comment 23

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1611528 - Fix rebase error r=BUSTAGE

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ffd665829e8
Fix rebase error r=BUSTAGE CLOSED TREE

Comment 25

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/553c8df1e87f
https://hg.mozilla.org/mozilla-central/rev/5e5900f8a83f
https://hg.mozilla.org/mozilla-central/rev/6ba5da3138a0
https://hg.mozilla.org/mozilla-central/rev/f9ee136e90db
https://hg.mozilla.org/mozilla-central/rev/21581ff62cd5
https://hg.mozilla.org/mozilla-central/rev/c3b8b8aea242
https://hg.mozilla.org/mozilla-central/rev/70bf5006862f
https://hg.mozilla.org/mozilla-central/rev/e74ba3ea5751
https://hg.mozilla.org/mozilla-central/rev/55bd40282d25
https://hg.mozilla.org/mozilla-central/rev/d9fa5bd2f4f8
https://hg.mozilla.org/mozilla-central/rev/f20ad70d5a12
https://hg.mozilla.org/mozilla-central/rev/1402b4275f5a
https://hg.mozilla.org/mozilla-central/rev/c7682a1018f5
https://hg.mozilla.org/mozilla-central/rev/c289ab3f98ec
https://hg.mozilla.org/mozilla-central/rev/6bdbfb767513
https://hg.mozilla.org/mozilla-central/rev/7fc17e3747ca
https://hg.mozilla.org/mozilla-central/rev/a803f02ebefe
https://hg.mozilla.org/mozilla-central/rev/4ed5534078c3
https://hg.mozilla.org/mozilla-central/rev/65ee98c30605
https://hg.mozilla.org/mozilla-central/rev/0dd7f7a0354b
https://hg.mozilla.org/mozilla-central/rev/cf8eeec663a2
https://hg.mozilla.org/mozilla-central/rev/2ffd665829e8