1611636 - Attachments not aligned properly in attachment pane on trunk 74 of 2020-01-25

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[Jorg K (CEST = GMT+2)]

Attachment: bad-attachment-alignment.png

See picture. This should be aligned horizontally.

Alice, can you please find the regression.

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=b4e1c22a54e49886946f3390c7369b1e5a1ce27c&tochange=e60c7640c9731b8be5780ceb72ad3c83784958cb
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e728bf01a2b60414e18ac3abed8af55d5ab35924&tochange=12fb5e522dd32b5ff50c8196c05b3ba9d244417e

Comment 2

[Jorg K (CEST = GMT+2)]

Thanks, Alice. I'm putting my money on bug 1606130.

Comment 3

[Jorg K (CEST = GMT+2)]

Maybe something like this is required now: https://hg.mozilla.org/mozilla-central/rev/6378942bfb04

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Yes, that is basically it.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: 1611636-attachmentItem-inline.patch

Yes, the display: -moz-inline-box; fixed it. I receive too little messages with attachments to spot it.

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 9123093 [details] [diff] [review]
1611636-attachmentItem-inline.patch

Review of attachment 9123093 [details] [diff] [review]:
-----------------------------------------------------------------

Thx! r=mkmelin

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c8aada5de259
Make the attachmentItem inline-level in the message pane attachment list. r=mkmelin