Closed Bug 1611678 Opened 4 years ago Closed 4 years ago

Clean up outdated plugin preferences in SeaMonkey.

Categories

(SeaMonkey :: General, task, P3)

Tracking

(seamonkey2.49esr wontfix, seamonkey2.53 fixed, seamonkey2.57esr fixed)

RESOLVED FIXED
seamonkey 2.73
Tracking Status
seamonkey2.49esr --- wontfix
seamonkey2.53 --- fixed
seamonkey2.57esr --- fixed

People

(Reporter: frg, Assigned: frg)

References

(Blocks 1 open bug)

Details

(Whiteboard: SM2.53.1)

Attachments

(2 files, 2 obsolete files)

We have some completly outdated plugin prefs plus handling in our code. 53 removed support for all NPAPI plugins but Flash so time to clean up:

2.57+

  • Bug 1421711 Remove dead pluginInstallerWizard.css and other plugin files.
Attached patch 1611678-plugins-253.patch (obsolete) — Splinter Review

Tested in 2.53 but I don't have flash installed so maybe try it with an older Flash version too.

Attachment #9123103 - Flags: review?(iann_bugzilla)
Attachment #9123103 - Flags: approval-comm-release?
Attachment #9123103 - Flags: approval-comm-esr60?

Dmitry, if you have some time could you test the patch a bit. If IanN gives his blessing we might take it to the final 2.53.1 then or I extract the HTMLAppletElement part into a separate one only for 2.53.1.

Flags: needinfo?(dmitry)

Works fine for me (Linux, CentOS7).

No more issues of https://bugzilla.mozilla.org/show_bug.cgi?id=1584803#c33 .

Have tested a bit with some old flash stuff.

forget to clear needinfo...

Flags: needinfo?(dmitry)
Comment on attachment 9123103 [details] [diff] [review]
1611678-plugins-253.patch

Thanks. The checkin comment need to reference bug 874167 not Bug 1190864. Will fix after r+ or in a next iteration.

I forgot to mention that I didn't find the original bug which removed pfs.datasource.url in mozilla-central. But it is gone for good for a long time.

(In reply to Frank-Rainer Grahl (:frg) from comment #6)

Comment on attachment 9123103 [details] [diff] [review]
1611678-plugins-253.patch

Thanks. The checkin comment need to reference bug 874167 not Bug 1190864.
Will fix after r+ or in a next iteration.

I forgot to mention that I didn't find the original bug which removed
pfs.datasource.url in mozilla-central. But it is gone for good for a long
time.

That would be Bug 1202193 which is a follow-up to Bug 836415. Also see TB Bug 1071069

Comment on attachment 9123103 [details] [diff] [review]
1611678-plugins-253.patch

Looking at https://hg.mozilla.org/mozilla-central/rev/d1ae4274cf8b I would say there is more work needed around missing plugins
f+ for the patch so far
Attachment #9123103 - Flags: review?(iann_bugzilla)
Attachment #9123103 - Flags: feedback+
Attachment #9123103 - Flags: approval-comm-release?
Attachment #9123103 - Flags: approval-comm-esr60?
Attached patch 1611678-plugins-253.patch (obsolete) — Splinter Review

[Approval Request Comment]
Regression caused by (bug #): see for checkin-comment
User impact if declined: Flash might not work in some specific cases because of a missing variable.
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): limited audience not risky.
String changes made by this patch: only removals

I hope I got everything. I left the plugins.hide_infobar_for_missing_plugin pref in. Still used for showing disabled or blocklisted plugins. Can die together with Flash later. If possible test with old vulnerable, a current and disabled/enabled flash.

2.57+ needs the mozapps/plugins/pluginGeneric*.png fixed and pluginInstallerWizard.css removed. Will add an addendum patch for it when this one here got r+.

Attachment #9123103 - Attachment is obsolete: true
Attachment #9123392 - Flags: review?(iann_bugzilla)
Attachment #9123392 - Flags: approval-comm-release?
Attachment #9123392 - Flags: approval-comm-esr60?
Comment on attachment 9123392 [details] [diff] [review]
1611678-plugins-253.patch

In Bug 870112 plugins.hide_infobar_for_missing_plugin migrated into plugins.notifyMissingFlash (which was then removed in Bug 836415) and plugins.hide_infobar_for_blocked_plugin was added (which was removed along with plugins.hide_infobar_for_outdated_plugin in Bug 880735 part D and Bug 1027049), so this needs fixing.

blocked-plugins tests were removed in Bug 880735 too (https://hg.mozilla.org/releases/mozilla-esr31/rev/3da4f4ddc8334c0475b9603b22d44faf3a3f5225)

There was other stuff removed in Bug 1129040 too

f+ for the other parts
Attachment #9123392 - Flags: review?(iann_bugzilla)
Attachment #9123392 - Flags: feedback+
Attachment #9123392 - Flags: approval-comm-release?
Attachment #9123392 - Flags: approval-comm-esr60?

Need some more time to look into the flash prefs so split the patch to be able to take part 1 to 2.53.1

[Approval Request Comment]
Regression caused by (bug #): Bug 1279218
User impact if declined: Flash activation might fail
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): already broken
String changes made by this patch: --

Attachment #9124358 - Flags: review?(iann_bugzilla)
Attachment #9124358 - Flags: approval-comm-release?
Attachment #9124358 - Flags: approval-comm-esr60?

part 2 still needs some work.

Attachment #9123392 - Attachment is obsolete: true
Keywords: leave-open
Attachment #9124358 - Attachment is patch: true
Attachment #9124359 - Attachment is patch: true
Comment on attachment 9124358 [details] [diff] [review]
Part 1 Remove check for HTMLAppletElement in SeaMonkey.

[Triage Comment]
r/a=me for 2.53.1
Attachment #9124358 - Flags: review?(iann_bugzilla)
Attachment #9124358 - Flags: review+
Attachment #9124358 - Flags: approval-comm-release?
Attachment #9124358 - Flags: approval-comm-release+
Attachment #9124358 - Flags: approval-comm-esr60?
Attachment #9124358 - Flags: approval-comm-esr60+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/63582aa9fdbe
Remove check for HTMLAppletElement in SeaMonkey. r=IanN
Comment on attachment 9124359 [details] [diff] [review]
Part 2 Clean up outdated plugin preferences in SeaMonkey

>+++ b/suite/browser/test/browser/browser_pluginnotification.js

>-  ok(!PopupNotifications.getNotification("click-to-play-plugins", gTestBrowser), "Test 9c, Click to play notification should be removed now");
>+    ok(!PopupNotifications.getNotification("click-to-play-plugins", gTestBrowser), "Test 9c, Click to play notification should be removed now");
Nit: did you really mean to change the indentation here?
Comment on attachment 9124359 [details] [diff] [review]
Part 2 Clean up outdated plugin preferences in SeaMonkey

[Triage Comment]
r/a=me but set a reminder to check the other changes.
Attachment #9124359 - Flags: review+
Attachment #9124359 - Flags: approval-comm-release+
Attachment #9124359 - Flags: approval-comm-esr60+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/6d347949d057
Clean up outdated plugin preferences in SeaMonkey. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: leave-open
Resolution: --- → FIXED
Target Milestone: --- → seamonkey 2.73
Blocks: 1625966
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: