Clean up outdated plugin preferences in SeaMonkey.
Categories
(SeaMonkey :: General, task, P3)
Tracking
(seamonkey2.49esr wontfix, seamonkey2.53 fixed, seamonkey2.57esr fixed)
People
(Reporter: frg, Assigned: frg)
References
(Blocks 1 open bug)
Details
(Whiteboard: SM2.53.1)
Attachments
(2 files, 2 obsolete files)
2.61 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-release+
iannbugzilla
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
35.37 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-release+
iannbugzilla
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
We have some completly outdated plugin prefs plus handling in our code. 53 removed support for all NPAPI plugins but Flash so time to clean up:
- Bug 1277905 "Remove plugincheck links from Firefox".
- Bug 1279218 "Remove <applet> element".
- Bug 874167 part A "remove nsNPAPIPlugin::RunPluginOOP and unused code paths"
which landed with the wrong bug number Bug 1090864. - Bug 836415 Kill PFS.
2.57+
- Bug 1421711 Remove dead pluginInstallerWizard.css and other plugin files.
Assignee | ||
Comment 1•4 years ago
|
||
Tested in 2.53 but I don't have flash installed so maybe try it with an older Flash version too.
Assignee | ||
Comment 2•4 years ago
|
||
Dmitry, if you have some time could you test the patch a bit. If IanN gives his blessing we might take it to the final 2.53.1 then or I extract the HTMLAppletElement part into a separate one only for 2.53.1.
Comment 3•4 years ago
|
||
Works fine for me (Linux, CentOS7).
No more issues of https://bugzilla.mozilla.org/show_bug.cgi?id=1584803#c33 .
Comment 4•4 years ago
|
||
Have tested a bit with some old flash stuff.
Assignee | ||
Comment 6•4 years ago
|
||
Comment on attachment 9123103 [details] [diff] [review] 1611678-plugins-253.patch Thanks. The checkin comment need to reference bug 874167 not Bug 1190864. Will fix after r+ or in a next iteration. I forgot to mention that I didn't find the original bug which removed pfs.datasource.url in mozilla-central. But it is gone for good for a long time.
(In reply to Frank-Rainer Grahl (:frg) from comment #6)
Comment on attachment 9123103 [details] [diff] [review]
1611678-plugins-253.patchThanks. The checkin comment need to reference bug 874167 not Bug 1190864.
Will fix after r+ or in a next iteration.I forgot to mention that I didn't find the original bug which removed
pfs.datasource.url in mozilla-central. But it is gone for good for a long
time.
That would be Bug 1202193 which is a follow-up to Bug 836415. Also see TB Bug 1071069
Comment on attachment 9123103 [details] [diff] [review] 1611678-plugins-253.patch Looking at https://hg.mozilla.org/mozilla-central/rev/d1ae4274cf8b I would say there is more work needed around missing plugins f+ for the patch so far
Assignee | ||
Comment 9•4 years ago
|
||
[Approval Request Comment]
Regression caused by (bug #): see for checkin-comment
User impact if declined: Flash might not work in some specific cases because of a missing variable.
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): limited audience not risky.
String changes made by this patch: only removals
I hope I got everything. I left the plugins.hide_infobar_for_missing_plugin pref in. Still used for showing disabled or blocklisted plugins. Can die together with Flash later. If possible test with old vulnerable, a current and disabled/enabled flash.
2.57+ needs the mozapps/plugins/pluginGeneric*.png fixed and pluginInstallerWizard.css removed. Will add an addendum patch for it when this one here got r+.
Comment 10•4 years ago
|
||
Comment on attachment 9123392 [details] [diff] [review] 1611678-plugins-253.patch In Bug 870112 plugins.hide_infobar_for_missing_plugin migrated into plugins.notifyMissingFlash (which was then removed in Bug 836415) and plugins.hide_infobar_for_blocked_plugin was added (which was removed along with plugins.hide_infobar_for_outdated_plugin in Bug 880735 part D and Bug 1027049), so this needs fixing. blocked-plugins tests were removed in Bug 880735 too (https://hg.mozilla.org/releases/mozilla-esr31/rev/3da4f4ddc8334c0475b9603b22d44faf3a3f5225) There was other stuff removed in Bug 1129040 too f+ for the other parts
Assignee | ||
Comment 11•4 years ago
|
||
Need some more time to look into the flash prefs so split the patch to be able to take part 1 to 2.53.1
[Approval Request Comment]
Regression caused by (bug #): Bug 1279218
User impact if declined: Flash activation might fail
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): already broken
String changes made by this patch: --
Assignee | ||
Comment 12•4 years ago
|
||
part 2 still needs some work.
Assignee | ||
Updated•4 years ago
|
Comment 13•4 years ago
|
||
Comment on attachment 9124358 [details] [diff] [review] Part 1 Remove check for HTMLAppletElement in SeaMonkey. [Triage Comment] r/a=me for 2.53.1
Comment 14•4 years ago
|
||
Pushed by frgrahl@gmx.net: https://hg.mozilla.org/comm-central/rev/63582aa9fdbe Remove check for HTMLAppletElement in SeaMonkey. r=IanN
Comment 15•4 years ago
|
||
Comment on attachment 9124359 [details] [diff] [review] Part 2 Clean up outdated plugin preferences in SeaMonkey >+++ b/suite/browser/test/browser/browser_pluginnotification.js >- ok(!PopupNotifications.getNotification("click-to-play-plugins", gTestBrowser), "Test 9c, Click to play notification should be removed now"); >+ ok(!PopupNotifications.getNotification("click-to-play-plugins", gTestBrowser), "Test 9c, Click to play notification should be removed now"); Nit: did you really mean to change the indentation here?
Comment 16•4 years ago
|
||
Comment on attachment 9124359 [details] [diff] [review] Part 2 Clean up outdated plugin preferences in SeaMonkey [Triage Comment] r/a=me but set a reminder to check the other changes.
Comment 17•4 years ago
|
||
Pushed by frgrahl@gmx.net: https://hg.mozilla.org/comm-central/rev/6d347949d057 Clean up outdated plugin preferences in SeaMonkey. r=IanN
Assignee | ||
Updated•4 years ago
|
Description
•