1611689 - Text in Search Bar are deleted after exit DOM FullScreen

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Alice0775 White]

Reproducible: always

Steps to reproduce:

1. Enable Search Bar
2. Type something in the Search Bar
3. Open any video
4. Enter DOM FullScreen and exit DOM FullScreen

Actual Results:
Text in Search Bar are deleted

Expected Results:
The text should be retained

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ac5fc1e491a2bb5481d47247bea3c2b22318001c&tochange=517c9efa9592ad0c103ec2542e4bc7fcaf06c505

Comment 1

[:Gijs (he/him)]

Dão, why do we even end up moving things into the overflow when we enter dom fullscreen? Seems like if we avoid that, we could fix bug 1601706 and bug 1607810 for now (though the symptoms there may be fixable otherwise, too).

Comment 2

[Dão Gottwald [:dao]]

(In reply to :Gijs (he/him) from comment #1)

Dão, why do we even end up moving things into the overflow when we enter dom fullscreen?

We get a resize event and then we get bogus overflow info (because this._toolbar.clientWidth is 0 I think).

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 1611689 - Make OverflowableToolbar::_checkOverflow return early in DOM fullscreen mode. r=gijs

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59c7ac9564d8
Make OverflowableToolbar::_checkOverflow return early in DOM fullscreen mode. r=Gijs

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/59c7ac9564d8

Comment 6

[Alice0775 White]

Reproduced with Nightly74.0a1 (20200128092639) Windows10.
And the issue is verified fixed with Nightly74.0a1 (20200128214036) Windows10.

Comment 7

[Alice0775 White]

Could you please nominate this for Beta to fix this bug, bug 1601706 and bug 1607810?

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 9123322 [details]
Bug 1611689 - Make OverflowableToolbar::_checkOverflow return early in DOM fullscreen mode. r=gijs

Beta/Release Uplift Approval Request

• User impact if declined: see comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: see comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Quite simple fix
• String changes made/needed:

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9123322 [details]
Bug 1611689 - Make OverflowableToolbar::_checkOverflow return early in DOM fullscreen mode. r=gijs

Fixes some regressions with DOM fullscreen mode. Approved for 73.0RC1.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/47218cad6957

Comment 11

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I can confirm this issue is fixed, I verified using Firefox 73.0 on Win 8.1 x64, macOS 10.14 and Ubuntu 18.04 x64.