Closed
Bug 1611745
Opened 4 years ago
Closed 4 years ago
GetProcAddress is not needed for QueryFullProcessImageNameW anymore
Categories
(Toolkit :: Startup and Profile System, task)
Tracking
()
RESOLVED
FIXED
mozilla74
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: alexhenrie24, Assigned: alexhenrie24)
Details
Attachments
(1 file)
ProfileUnlockerWin.cpp currently calls GetProcAddress to get a pointer to QueryFullProcessImageNameW. This is no longer necessary because this function is guaranteed to be available from Windows Vista on, and Firefox no longer supports Windows XP. Furthermore, the same file already calls several other functions in kernel32.dll without using GetProcAddress.
|
||
Comment 1•4 years ago
|
||
Moreover, Launcher Process already calls QueryFullProcessImageNameW without using GetProcAddress:
https://searchfox.org/mozilla-central/rev/aa684c0c76136be80af4c6e429bce81dea55c429/browser/app/winlauncher/SameBinary.h#28
|
Assignee | |
Comment 2•4 years ago
|
||
|
||
Updated•4 years ago
|
Assignee: nobody → alexhenrie24
Status: NEW → ASSIGNED
Pushed by cbrindusan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7cde282c17e5 Link to QueryFullProcessImageNameW at compile time. r=mossop
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in
before you can comment on or make changes to this bug.
Description
•