Closed Bug 1611791 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21432 - Stop dispatching SMIL events while seeking

Categories

(Core :: SVG, task, P4)

Product:
Core
Component:
SVG
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla75
Tracking Flags:
Tracking Status
firefox75 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21432 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21432
Details from upstream follow.

Fredrik Söderquist <fs@opera.com> wrote:

Stop dispatching SMIL events while seeking

Based on [1], 'beginEvent' and 'endEvent' should only be dispatched for
elements that are active at the seeked-to time and elements that were
active at the previous/old/seeked-from time but are inactive at the
seeked-to time (respectively). 'repeatEvent's should not be disaptched
while seeking.

To handle this, extend the TimingUpdate helper class with a map that
tracks what interval the active elements had before the seek operation,
and whether the timing update operation is a seek operation (called
"fast-forward" since we end up moving in the forward direction
regardless of the actual seek direction).
Apart from that, the dispatching of 'repeatEvent's are also inhibited,
as well as the notifications of repeats in general.

[1] https://www.w3.org/TR/SMIL3/smil-timing.html#q114

Bug: 1039886
Change-Id: I17d91b1355858ee0b916d4fa46b9572e685e40e5

Reviewed-on: https://chromium-review.googlesource.com/2020947
WPT-Export-Revision: 3ddf1274d8a77bf59040f386a35b4b87bb6cdfd5

Component: web-platform-tests → SVG
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 8 tests and 1 subtests

Status Summary

Firefox

OK : 6
PASS : 6
TIMEOUT: 4

Chrome

OK : 8
FAIL : 8

Safari

OK : 8
PASS : 1
FAIL : 7

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/svg/animations/seeking-events-7.html: TIMEOUT
/svg/animations/seeking-events-8.html: TIMEOUT

New Tests That Don't Pass

/svg/animations/seeking-events-7.html: TIMEOUT (Chrome: OK, Safari: OK)
Seeking forwards to a new interval dispatches both 'endEvent' and 'beginEvent': TIMEOUT (Chrome: FAIL, Safari: FAIL)
/svg/animations/seeking-events-8.html: TIMEOUT (Chrome: OK, Safari: OK)
Seeking backwards to a new interval dispatches both 'endEvent' and 'beginEvent': TIMEOUT (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2fb8f6c788f1
[wpt PR 21432] - Stop dispatching SMIL events while seeking, a=testonly
https://hg.mozilla.org/integration/autoland/rev/06c1844da78f
[wpt PR 21432] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/2fb8f6c788f1
https://hg.mozilla.org/mozilla-central/rev/06c1844da78f

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox75: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.