Add Cc/Bcc addressing field should be reported to screen reader as button
Categories
(Thunderbird :: Message Compose Window, defect)
Tracking
(Not tracked)
People
(Reporter: foss, Assigned: Paenglab)
Details
(Keywords: access)
Attachments
(1 file, 1 obsolete file)
11.62 KB,
patch
|
Paenglab
:
review+
|
Details | Diff | Splinter Review |
Hello,
Steps to reproduce:
- Launch a screen reader like Orca or NVDA (optional)
- Open the message compose window
- Press shift + tab two times to go on "CCi / BCC" (I've the French version so I don't known the exact English word)
Result with the screen reader:
It says "CCi / BCC" or "CC" label
Expected result:
The reported type of those element should be button because it should be and also for consistency because in all over the OS the user never hears "label" but only "XX button".
Best regards.
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
This adds the role="button" to the labels. I also added the role to the remove row buttons (close-icon). But this close buttons need also some description label/tooltip. I don't add them here as this will be done in bug 1609977.
Updated•4 years ago
|
Comment 2•4 years ago
|
||
Comment on attachment 9124378 [details] [diff] [review] 1611793-recipient-label-role-button.patch Review of attachment 9124378 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for taking care of this. Looks good to me. r=aleca
Comment 3•4 years ago
|
||
Can you update the commit message to:
"Add role="button" attribute to the recipient labels to show screen readers the correct function"
Assignee | ||
Comment 4•4 years ago
|
||
Thanks. Updated the commit text. I don't ask for approval beta as there will be probably none.
Assignee | ||
Updated•4 years ago
|
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/8e4805dafb1a
Add role="button" attribute to the recipient labels to show screen readers the correct function. r=aleca DONTBUILD
Updated•4 years ago
|
Assignee | ||
Comment 6•4 years ago
|
||
Alex, can you test today Daily, which is out in about two hours, if this is the right fix?
Reporter | ||
Comment 7•4 years ago
|
||
(In reply to Richard Marti (:Paenglab) from comment #6)
Alex, can you test today Daily, which is out in about two hours, if this is the right fix?
I confirm that it works as expected on latest daily with the Orca screen reader on my Debian 10.
Thanks for the fix.
Description
•