Closed Bug 1611793 Opened 4 years ago Closed 4 years ago

Add Cc/Bcc addressing field should be reported to screen reader as button

Categories

(Thunderbird :: Message Compose Window, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 74.0

People

(Reporter: foss, Assigned: Paenglab)

Details

(Keywords: access)

Attachments

(1 file, 1 obsolete file)

Hello,

Steps to reproduce:

  1. Launch a screen reader like Orca or NVDA (optional)
  2. Open the message compose window
  3. Press shift + tab two times to go on "CCi / BCC" (I've the French version so I don't known the exact English word)

Result with the screen reader:
It says "CCi / BCC" or "CC" label

Expected result:
The reported type of those element should be button because it should be and also for consistency because in all over the OS the user never hears "label" but only "XX button".

Best regards.

Keywords: access
Summary: Add CC or CCI label should be reported to screen reader as button → Add Cc/Bcc addressing field should be reported to screen reader as button
Assignee: nobody → alessandro

This adds the role="button" to the labels. I also added the role to the remove row buttons (close-icon). But this close buttons need also some description label/tooltip. I don't add them here as this will be done in bug 1609977.

Attachment #9124378 - Flags: review?(alessandro)
Assignee: alessandro → richard.marti
Status: NEW → ASSIGNED
Comment on attachment 9124378 [details] [diff] [review]
1611793-recipient-label-role-button.patch

Review of attachment 9124378 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for taking care of this. Looks good to me.
r=aleca
Attachment #9124378 - Flags: review?(alessandro) → review+

Can you update the commit message to:
"Add role="button" attribute to the recipient labels to show screen readers the correct function"

Thanks. Updated the commit text. I don't ask for approval beta as there will be probably none.

Attachment #9124378 - Attachment is obsolete: true
Attachment #9124427 - Flags: review+

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/8e4805dafb1a
Add role="button" attribute to the recipient labels to show screen readers the correct function. r=aleca DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 74.0

Alex, can you test today Daily, which is out in about two hours, if this is the right fix?

Flags: needinfo?(aarnaud)

(In reply to Richard Marti (:Paenglab) from comment #6)

Alex, can you test today Daily, which is out in about two hours, if this is the right fix?

I confirm that it works as expected on latest daily with the Orca screen reader on my Debian 10.

Thanks for the fix.

Flags: needinfo?(aarnaud)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: