Closed Bug 1611814 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 21438 - Implement commitStyles for web animations.

Categories

(Core :: DOM: Animation, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21438 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21438
Details from upstream follow.

Kevin Ellis <kevers@chromium.org> wrote:

Implement commitStyles for web animations.

CommitStyles provides a convenient way to update the style of an
element, avoiding the need to keep finished animations persistent
in order to stack effects.

A typical use case is:

const anim = elem.animate(keyframes, {..., fill: 'forward'});
anim.finished.then(() => {
anim.commitStyles();
anim.cancel();
});

Spec:
https://drafts.csswg.org/web-animations-1/#dom-animation-commitstyles

Intent:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/H5sz_dg6fKc/1X7K7U4XCgAJ

Bug: 981905
Change-Id: I37f61960480517e0a8f3427938cf799de4c6e9c8
Reviewed-on: https://chromium-review.googlesource.com/2017673
WPT-Export-Revision: 01d36b01144f4ed9adcb91c58b2b20ecf7388f98

Component: web-platform-tests → DOM: Animation
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 20 subtests

Status Summary

Firefox

OK : 1
PASS: 17
FAIL: 3

Chrome

OK : 1
FAIL: 20

Safari

OK : 1
PASS: 12
FAIL: 8

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/web-animations/interfaces/Animation/commitStyles.html
Throws if the target element is a pseudo element: FAIL (Chrome: FAIL, Safari: FAIL)
Commits custom variables: FAIL (Chrome: FAIL, Safari: FAIL)
Checks the pseudo element condition before the not rendered condition: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d4e5a1c7930d
[wpt PR 21438] - Implement commitStyles for web animations., a=testonly
https://hg.mozilla.org/integration/autoland/rev/a5f8ff0dc5ca
[wpt PR 21438] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.