Closed
Bug 1611815
Opened 4 years ago
Closed 4 years ago
performance-new in devtools is broken, as it doesn't handle the presetName
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect, P1)
Tracking
(firefox74 fixed)
RESOLVED
FIXED
Firefox 74
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: gregtatum, Assigned: gregtatum)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
|
Bug 1611815 - Fix thrown error about presetName om the performance-new devtools panel; r?canaltinova
47 bytes,
text/x-phabricator-request
|
Details | Review |
Error: Given action "INITIALIZE_STORE", reducer "presetName" returned undefined. To ignore an action, you must explicitly return the previous state. If you want this reducer to hold no value, you can return null instead of undefined. redux.js:506:15
|
Assignee | |
Comment 1•4 years ago
|
||
The reducer errors in the implementation of the DevTools panel, as the presetName was not being fetched from the preferences in the debuggee. This fixes that. TypeScript caught this, but I guess I forgot to check it.
Pushed by gtatum@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/310f3e7947c8 Fix thrown error about presetName om the performance-new devtools panel; r=canaltinova
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox74:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
|
||
Updated•4 years ago
|
Has Regression Range: --- → yes
Keywords: regression
You need to log in
before you can comment on or make changes to this bug.
Description
•