Closed Bug 1611856 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21448 - Cancel rather than block navigations which violate portals 1P rules.

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox75 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla75
Tracking Flags:
Tracking Status
firefox75 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21448 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21448
Details from upstream follow.

Jeremy Roman <jbroman@chromium.org> wrote:

Cancel rather than block navigations which violate portals 1P rules.

Since this can lead to a WebContents with no committed entries, deal
with that case in the browser-side Activate logic, by rejecting
activations which occur before we can say with certainty that we
will load a page (i.e. navigation commit).

Bug: 1046121,1034740,942198
Change-Id: Icd219dc0bb1e4a9ab6fdc433f8644c14e69964e4

Reviewed-on: https://chromium-review.googlesource.com/2015768
WPT-Export-Revision: ae6c2ae46172c5403a9d5e314c8cc5738576ead9

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 44 tests

Status Summary

Firefox

PASS : 43
TIMEOUT: 2
NOTRUN : 1

Chrome

TIMEOUT: 2
NOTRUN : 1

Safari

TIMEOUT: 2
NOTRUN : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/portals/predecessor-fires-unload.html: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
pagehide and unload should fire if the predecessor is not adopted: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
pagehide and unload should fire if the predecessor is not adopted, even without a window/opener association: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4588c5df9b6c
[wpt PR 21448] - Cancel rather than block navigations which violate portals 1P rules., a=testonly
https://hg.mozilla.org/integration/autoland/rev/3d3fd18bea7d
[wpt PR 21448] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/4588c5df9b6c
https://hg.mozilla.org/mozilla-central/rev/3d3fd18bea7d

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox75: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.