1611985 - servo-tidy confused about raw strings

Status: RESOLVED WONTFIX

(Core :: Graphics: WebRender, defect, P3)

Description

[Bert Peers [:bpeers]]

It looks like webrender-lint-tidy doesn't understand r# strings, so it will complain about missing spaces before/after { and } when it shouldn't.

For example this:
format!(r#"{}<rect x="{:.2}" y="{:.2}" width="{:.2}" height="{:.2}" {}/>"#,
needs to be rewritten as
format!("<rect x=\"{:.2}\" y=\"{:.2}\" width=\"{:.2}\" height=\"{:.2}\" {}/>",
to pass try fuzzy.

Comment 1

[Bert Peers [:bpeers]]

To be honest I'm not sure if the problem is due to raw strings or if it's the nested strings that confused it. For example in the code below, I had to use unicode to "hide" the = and :, otherwise tidy would complain that assignment and declaration need spaces around them:

    let svg_begin = "<?xml\u{2d}stylesheet type\u{3d}\"text/css\" href\u{3d}\"tilecache_base.css\" ?>\n\
                     <?xml\u{2d}stylesheet type\u{3d}\"text/css\" href\u{3d}\"tilecache.css\" ?>\n";