1612073 - [wpt-sync] Sync PR 21486 - Separated willValidate check in HTMLInputElement::validationMessage

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 21486 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21486
Details from upstream follow.

Kei Nakashima <[e-mail]> wrote:

Separated willValidate check in HTMLInputElement::validationMessage

This change is for following the spec of validationMessage.
It affects the situation where willValidate is false and
actual validation message exists.
It enables validationMessage to return empty string in this situation.

Bug:1046211
Change-Id: Ie501535464b61366c81ee08d6b234fb52cc076f6
Reviewed-on: https://chromium-review.googlesource.com/2024132
WPT-Export-Revision: 237b5535a3003e71b5eeba997bf361872da505dc

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=3519842d65cf2bf83ca196be0640119296417d33

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 44 tests

Status Summary

Firefox

OK : 1
PASS: 92[GitHub] 135[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL: 4

Chrome

OK : 1
PASS: 93
FAIL: 3

Safari

OK : 1
PASS: 41
FAIL: 9

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/html/semantics/forms/constraints/form-validation-validity-valueMissing.html
[INPUT in RADIO status] The checked attribute is false and the name attribute is empty: FAIL

New Tests That Don't Pass

/html/semantics/forms/constraints/form-validation-validity-valueMissing.html
[INPUT in CHECKBOX status] The checked attribute is false: FAIL (Chrome: PASS, Safari: FAIL)
[INPUT in RADIO status] The checked attribute is false and the name attribute is empty: FAIL (Chrome: PASS, Safari: PASS)
[INPUT in RADIO status] The checked attribute is false: FAIL (Chrome: PASS, Safari: FAIL)
[INPUT in FILE status] The Files attribute is null: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25c6ff4684cc
[wpt PR 21486] - Separated willValidate check in HTMLInputElement::validationMessage, a=testonly

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/25c6ff4684cc