1612077 - Use parallel directory processing for Lint when no path is specified or a support file is touched

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P2)

Description

[Mark Banner (:standard8)]

At the moment, if a developer does ./mach eslint or changes a support file, then we run lint in single-process mode, rather than multi-process.

I have a patch that fixes this.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1612077 - Use parallel directory processing for Lint when no path is specified or a support file is touched. r?ahal

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b60a11f4550
Use parallel directory processing for Lint when no path is specified or a support file is touched. r=ahal

Comment 4

[Alexandru Michis [:malexandru]]

Backed out changeset 9b60a11f4550 for causing failures in mozlint/test/test_roller.py

Backout link: https://hg.mozilla.org/integration/autoland/rev/f45e3b4314a1c83ce14be7afa1ea2ab43d154f45

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=9b60a11f45500b120f31de4c089199a58e2d12da&selectedJob=290984731

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=290984731&repo=autoland&lineNumber=486

Comment 5

[Mark Banner (:standard8)]

Working on it.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b2c3a0fa051
Use parallel directory processing for Lint when no path is specified or a support file is touched. r=ahal

Comment 7

[Narcis Beleuzu [:NarcisB]]

Backed out for lint failures on test_support_files.py

Backout link: https://hg.mozilla.org/integration/autoland/rev/912a56bb367db0c2de3d260b0129e70bf911b3d8
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=291272948&repo=autoland&lineNumber=511

Also Linting opt : https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=291292268&repo=autoland&lineNumber=1073

Comment 8

[Mark Banner (:standard8)]

(In reply to Narcis Beleuzu [:NarcisB] from comment #7)

Backed out for lint failures on test_support_files.py

Backout link: https://hg.mozilla.org/integration/autoland/rev/912a56bb367db0c2de3d260b0129e70bf911b3d8
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=291272948&repo=autoland&lineNumber=511

Strange, will look at this.

Also Linting opt : https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=291292268&repo=autoland&lineNumber=1073

This has nothing to do with this patch.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/502458052810
Use parallel directory processing for Lint when no path is specified or a support file is touched. r=ahal

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/502458052810