1612148 - Convert transform-style #defines to an enum class.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P3)

Description

[Martin McNickle]

See all the already-fixed bugs blocking bug 1277133 for existing examples of how to fix this.

Comment 1

[Thomas Dolezal]

Attachment: Bug 1612148 - Replace transform style defines to an enum class. r-emilio

Comment 2

[Thomas Dolezal]

Attachment: Bug 1612148 - Replace transform style defines to an enum class. r=emilio

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c1831f15450
Replace transform style defines to an enum class. r=emilio

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1432ef26779
followup: Remove unused include.

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for reftest failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/a1831166322335aa3a26009818ecd639f40c63ad
There are multiple reftest failures.
Log link1: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=287173092&repo=autoland&lineNumber=17732
Log link2: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=287173109&repo=autoland&lineNumber=12457
Log link3: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=287173437&repo=autoland&lineNumber=17570

Comment 6

[Emilio Cobos Álvarez (:emilio)]

The bug was in the auto-generated tool, it wasn't handling the #[cfg] in the particular enum variant.

https://github.com/eqrion/cbindgen/pull/469 is the fix for that, but we can work-around it in the meantime. I'll update the patch to remove the TransformStyle::Auto variant, as it is not needed for Gecko and Servo should probably remove it as it behaves just as Gecko anyway.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75a4bfbe9fa1
Replace transform style defines to an enum class. r=emilio

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/75a4bfbe9fa1