Convert transform-style #defines to an enum class.
Categories
(Core :: CSS Parsing and Computation, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox74 | --- | fixed |
People
(Reporter: martin, Assigned: thomas.dolezal, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [lang=c++][lang=rust] )
Attachments
(1 file, 1 obsolete file)
See all the already-fixed bugs blocking bug 1277133 for existing examples of how to fix this.
Reporter | ||
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 5•5 years ago
|
||
Backed out for reftest failures
Backout link: https://hg.mozilla.org/integration/autoland/rev/a1831166322335aa3a26009818ecd639f40c63ad
There are multiple reftest failures.
Log link1: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=287173092&repo=autoland&lineNumber=17732
Log link2: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=287173109&repo=autoland&lineNumber=12457
Log link3: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=287173437&repo=autoland&lineNumber=17570
Comment 6•5 years ago
|
||
The bug was in the auto-generated tool, it wasn't handling the #[cfg]
in the particular enum variant.
https://github.com/eqrion/cbindgen/pull/469 is the fix for that, but we can work-around it in the meantime. I'll update the patch to remove the TransformStyle::Auto
variant, as it is not needed for Gecko and Servo should probably remove it as it behaves just as Gecko anyway.
Updated•5 years ago
|
Updated•5 years ago
|
Comment 8•5 years ago
|
||
bugherder |
Description
•