Closed Bug 1612148 Opened 9 months ago Closed 9 months ago

Convert transform-style #defines to an enum class.

Categories

(Core :: CSS Parsing and Computation, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: martin, Assigned: thomas.dolezal, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=c++][lang=rust] )

Attachments

(1 file, 1 obsolete file)

See all the already-fixed bugs blocking bug 1277133 for existing examples of how to fix this.

Blocks: 1277133
Keywords: good-first-bug
Whiteboard: [lang=c++][lang=rust]
Mentor: emilio
Priority: -- → P3
Assignee: nobody → thomas.dolezal
Status: NEW → ASSIGNED
Attachment #9123891 - Attachment description: Bug 1612148 - Replace transform style defines to an enum class. r-emilio → Bug 1612148 - Replace transform style defines to an enum class.
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0c1831f15450
Replace transform style defines to an enum class. r=emilio
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/e1432ef26779
followup: Remove unused include.

The bug was in the auto-generated tool, it wasn't handling the #[cfg] in the particular enum variant.

https://github.com/eqrion/cbindgen/pull/469 is the fix for that, but we can work-around it in the meantime. I'll update the patch to remove the TransformStyle::Auto variant, as it is not needed for Gecko and Servo should probably remove it as it behaves just as Gecko anyway.

Flags: needinfo?(emilio)
Attachment #9123891 - Attachment description: Bug 1612148 - Replace transform style defines to an enum class. → Bug 1612148 - Replace transform style defines to an enum class. r=emilio
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/75a4bfbe9fa1
Replace transform style defines to an enum class. r=emilio
Attachment #9123881 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.