1612182 - OTR button with dark theme hardly readable

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

When the dark theme is used, the OTR button has a grey background and white text, see attachment 9123250 [details].

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1612182-otr-button-dark-theme.patch

This fixes the issue by styling the button completely like we do for the toolbar button in the main toolbar.

I removed the toolbarbutton-1 class in chat-conversation-info.js because this is never used and immediately removed when the button is initialized.

Comment 2

[Alessandro Castellani [:aleca] - PTO until Nov 16]

Comment on attachment 9123552 [details] [diff] [review]
1612182-otr-button-dark-theme.patch

Review of attachment 9123552 [details] [diff] [review]:
-----------------------------------------------------------------

Indeed, this fixes the issue with the button.
I see the notification now is cut and doesn't expand entirely. There should be a button down there.
Is this issue already filed somewhere?
This is definitely a regression as I implemented that UI and it was working.

Comment 3

[Richard Marti (:Paenglab)]

I don't know which notification and I havn't filed a bug. I know nothing about OTR. I have only seen the button in the screenshot and fixed it.

Comment 4

[Magnus Melin [:mkmelin]]

I filed bug 1612306.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/779c55ffd47b
Style the otr-button also for dark themes. r=aleca

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 9123552 [details] [diff] [review]
1612182-otr-button-dark-theme.patch

No more betas this cycle