1612239 - Replace idl nsIArray usage with Array<T> in mailnews/base/public/

Status: RESOLVED FIXED

(MailNews Core :: General, task)

Description

[Ben Campbell]

This covers:

mailnews/base/public/nsIMsgFolderNotificationService.idl
mailnews/base/public/nsIMsgCopyService.idl
mailnews/base/public/nsIMsgPluggableStore.idl
mailnews/base/public/nsIMsgFolderListener.idl
mailnews/base/public/nsIMsgFolder.idl
mailnews/base/public/nsIMsgFolderCompactor.idl
mailnews/base/public/nsIMsgAccount.idl
mailnews/base/public/nsIMsgAccountManager.idl

searchfox query

Comment 1

[Ben Campbell]

mailnews/base/public/nsIMsgAccountManager.idl deserved its own Bug - see Bug 1614846.

Comment 2

[Ben Campbell]

Attachment: [checked in] 1612239-nsIMsgAccount-1.patch (landed in comment 5)

This one converts nsIMsgAccount.identities.
Try build:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&selectedJob=296033067&revision=8177d78bfc385d1c5ae617427cf75dd2814f731f

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9137950 [details] [diff] [review]
[checked in] 1612239-nsIMsgAccount-1.patch (landed in comment 5)

Review of attachment 9137950 [details] [diff] [review]:
-----------------------------------------------------------------

::: calendar/base/modules/utils/calItipUtils.jsm
@@ +507,5 @@
>        return null;
>      }
>  
>      let identities;
>      let actMgr = MailServices.accounts;

While we're here I'd get rid of this and use MailServices.accounts directly where needed

Comment 4

[Paul Morris [:pmorris]]

Comment on attachment 9137950 [details] [diff] [review]
[checked in] 1612239-nsIMsgAccount-1.patch (landed in comment 5)

Review of attachment 9137950 [details] [diff] [review]:
-----------------------------------------------------------------

r+ for calendar changes.  Good to see all these updates.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/588fc64ebcb0
Remove nsIArray usage in nsIMsgAccount. r=mkmelin,pmorris DONTBUILD

Comment 6

[Ben Campbell]

Attachment: [checked in] 1612239-nsIArray-removal-from-msgdelete-1.patch (landed in comment 9)

This one kept spilling out, so in the end I converted a bunch of related interfaces in different .idl files rather than a whole .idl file at once. The ones affected here are:

nsIMsgFolderListener.msgsDeleted()
nsIMsgFolderNotificationService.notifyMsgsDeleted()
nsIMsgPluggableStore.deleteMessages()
nsIMsgPluggableStore.changeFlags()

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 9141141 [details] [diff] [review]
[checked in] 1612239-nsIArray-removal-from-msgdelete-1.patch (landed in comment 9)

Review of attachment 9141141 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 8

[Magnus Melin [:mkmelin]]

Green try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=7a0fdb1a9d208c700d447be0d2b1625f6532d9da

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c1a719a87041
Remove nsIArray usage from various calls related to message deletion. r=mkmelin

Comment 10

[Ben Campbell]

Attachment: [checked in] 1612239-nsIArray-removal-from-msgClassified-1.patch (landed in comment 12)

Try build here.
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=7766f7b3f76d48648ec41face1c8aa552a70ea51
There's a bunch of orange, but I don't think they're related to this patch. Still maybe better to hold off a little and get a clear try run?

Comment 11

[Magnus Melin [:mkmelin]]

Comment on attachment 9143311 [details] [diff] [review]
[checked in] 1612239-nsIArray-removal-from-msgClassified-1.patch (landed in comment 12)

Review of attachment 9143311 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. The try run also looks fine (under the circumstances).

::: mailnews/imap/src/nsImapMailFolder.cpp
@@ +6885,5 @@
> +      nsMsgLabelValue label;
> +      msgDBHdr->GetLabel(&label);
> +      if (label != 0) {
> +        nsAutoCString labelStr;
> +        labelStr.AppendInt(label);

Oh the joy of pointless typedeffing (nsMsgLabelValue)...

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e7ab0d2b7290
Remove nsIArray use in nsIMsgFolderListener.msgsClassified(). r=mkmelin

Comment 13

[Ben Campbell]

Attachment: 1612239-remove-nsIArray-from-nsIMsgPluggableStore-changeKeywords-1.patch

Comment 14

[Ben Campbell]

Attachment: 1612239-remove-nsIArray-from-msgsMoveCopyCompleted-1.patch

try run looks good:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=2a80729d78acd29d0f52c58049c04ba4dd4e3ad9

Comment 15

[Magnus Melin [:mkmelin]]

Comment on attachment 9149670 [details] [diff] [review]
1612239-remove-nsIArray-from-msgsMoveCopyCompleted-1.patch

Review of attachment 9149670 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/db/gloda/modules/IndexMsg.jsm
@@ +2441,5 @@
>              GlodaDatastore._mapFolder(srcMsgFolder).dirtyStatus ==
>                GlodaFolder.prototype.kFolderFilthy
>            ) {
>              // Local case, just modify the destination headers directly.
> +            if (aDestMsgHdrs.length > 0) {

no need to check the length. if length is 0 it just won't loop, which is no big deal

::: mailnews/imap/src/nsImapMailFolder.cpp
@@ +4940,5 @@
> +        if (imapAction == nsIImapUrl::nsImapOnlineMove) {
> +          nsTArray<RefPtr<nsIMsgDBHdr>> hdrs;
> +          MsgHdrsToTArray(m_copyState->m_messages, hdrs);
> +          notifier->NotifyMsgsMoveCopyCompleted(true, hdrs, this, {});
> +

nit: extra empty line here

::: mailnews/test/resources/folderEventLogHelper.js
@@ +86,1 @@
>        args.push(msgHdr);

instead of looping, could just do

args.concat(aSrcMsgs);

or args.push(... aSrcMsgs);

@@ +93,1 @@
>          args.push(msgHdr);

same here

Comment 16

[Magnus Melin [:mkmelin]]

Comment on attachment 9149669 [details] [diff] [review]
1612239-remove-nsIArray-from-nsIMsgPluggableStore-changeKeywords-1.patch

Review of attachment 9149669 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/local/src/nsMsgBrkMBoxStore.cpp
@@ +844,5 @@
>    nsCOMPtr<nsIOutputStream> outputStream;
>    nsCOMPtr<nsISeekableStream> seekableStream;
>    int64_t restoreStreamPos;
>  
> +  if (aHdrArray.IsEmpty()) return NS_ERROR_INVALID_ARG;

would be nicer to have this first in the method

::: mailnews/local/src/nsMsgMaildirStore.cpp
@@ +1326,4 @@
>    nsCOMPtr<nsIOutputStream> outputStream;
>    nsCOMPtr<nsISeekableStream> seekableStream;
>  
> +  if (aHdrArray.IsEmpty()) return NS_ERROR_INVALID_ARG;

ditto

Comment 17

[Ben Campbell]

Attachment: [checked in] 1612239-remove-nsIArray-from-nsIMsgPluggableStore-changeKeywords-2.patch

Comment 18

[Ben Campbell]

Attachment: [checked in] 1612239-remove-nsIArray-from-msgsMoveCopyCompleted-2.patch

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bc7e17995e19
Remove nsIArray use from nsIMsgPluggableStore.changeKeywords(). r=mkmelin
https://hg.mozilla.org/comm-central/rev/1f1357f245c1
Remove nsIArray usage for msgsMoveCopyCompleted notification. r=mkmelin DONTBUILD

Comment 20

[Ben Campbell]

Attachment: [checked in] 1612239-remove-nsIArray-from-nsIMsgFolder-descendants-1.patch

Comment 21

[Ben Campbell]

Attachment: [checked in] 1612239-remove-nsIMsgFolder-ListDescendants-1.patch

Replaces nsIMsgFolder.ListDescendants() with nsIMsgFolder.descendants (which is simpler and clearer - ListDescendants() appended to the passed-in array).

These two descendants-related patches are covered by this try run:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=39de08a7f5f31704ce13b59d4615391944a3b6aa
(There's a third patch in there for nsIFolderCompactor, but I'll hold back until these two are clear)

Comment 22

[Magnus Melin [:mkmelin]]

Comment on attachment 9152976 [details] [diff] [review]
[checked in] 1612239-remove-nsIMsgFolder-ListDescendants-1.patch

Review of attachment 9152976 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/61ac6bd14371
Remove nsIArray usage from nsIMsgFolder.descendants. r=mkmelin
https://hg.mozilla.org/comm-central/rev/e16540d657cc
Remove redundant nsIMsgFolder.ListDescendants(). r=mkmelin DONTBUILD

Comment 24

[Ben Campbell]

Attachment: [checked in] 1612239-remove-nsIArray-from-nsIMsgFolderCompactor-1.patch

The logic in nsFolderCompactState::CompactFolders() was a little tricky to follow, but I've tried to clarify it a bit in the patch. Basically there are three cases:

• folders only
• folders and offline folders (the offline folders are saved in m_offlineFolderArray and a new nsFolderCompactState instance is spawned to process them when the other folders have finished).
  -offline folders only (m_compactingOfflineFolders is set to true )

Comment 25

[Ben Campbell]

Oh, forgot to add: the nsIMsgFolderCompactor patch was included in the previous try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=39de08a7f5f31704ce13b59d4615391944a3b6aa

Comment 26

[Magnus Melin [:mkmelin]]

Comment on attachment 9153327 [details] [diff] [review]
[checked in] 1612239-remove-nsIArray-from-nsIMsgFolderCompactor-1.patch

Review of attachment 9153327 [details] [diff] [review]:
-----------------------------------------------------------------

Looks ok to me. r=mkmelin

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2db662df8f37
Remove nsIArray usage from nsIMsgFolderCompactor. r=mkmelin

Comment 28

[Ben Campbell]

Attachment: 1612239-remove-nsIArray-from-nsIMsgCopyService-copyFolders-1.patch

Try run here, which looks good:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=8fbecff076633fa09255c5b66355be20b0be5a7f

This one took a whole heap of debugging. It broke lots of tests, and I'm not entirely sure what change got it working. I was looking at the wrong bug a lot of the time - turns out I'd triggered a pre-existing issue where copying an empty folder never finished (nsMsgLocalMailFolder::CopyFolderAcrossServer() was notifying on the wrong folder). I think somewhere while I was being misled on that one, I accidentally fixed whatever it was I'd broken. Sigh.

Long story short: Keep an eye out, the nsIMessageCopyService code seems to have some fragility to it...

Comment 29

[Magnus Melin [:mkmelin]]

Comment on attachment 9153723 [details] [diff] [review]
1612239-remove-nsIArray-from-nsIMsgCopyService-copyFolders-1.patch

Review of attachment 9153723 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/base/src/nsMsgCopyService.cpp
@@ +486,4 @@
>    nsCOMPtr<nsIMsgFolder> curFolder;
>    nsCOMPtr<nsISupports> support;
>  
> +  MOZ_ASSERT(folders.Length() == 1);  // Can only copy one folder.

Why are we passing in an array then?
At the very least this should throw a runtime error instead - it's accessible from js.

Comment 30

[Ben Campbell]

Attachment: [checked in] 1612239-remove-nsIArray-from-nsIMsgCopyService-copyFolders-2.patch

(In reply to Magnus Melin [:mkmelin] from comment #29)

::: mailnews/base/src/nsMsgCopyService.cpp
@@ +486,4 @@

nsCOMPtr<nsIMsgFolder> curFolder;
nsCOMPtr<nsISupports> support;

• MOZ_ASSERT(folders.Length() == 1); // Can only copy one folder.

Why are we passing in an array then?

I had enough grief with this patch that I figured that could be handled in another bug (I've just written it up - Bug 1643208).

At the very least this should throw a runtime error instead - it's
accessible from js.

Good point. New patch returns NS_ERROR_INVALID_ARG if the array isn't just a single folder.

Comment 31

[Ben Campbell]

Attachment: [checked in] 1612239-remove-nsIArray-from-nsIMsgPluggableStore-copyMessages-1.patch

This one is pretty self contained and shouldn't clash with other patches in this series.
Try run looks OK:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=d2a5f0935ad717696232a205b90fff053fbd0fc0

Comment 32

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4f8d3dff196e
Remove nsIArray use from nsIMsgCopyService.copyFolders. r=mkmelin
https://hg.mozilla.org/comm-central/rev/c74497b57d8c
Remove nsIArray usage from nsIMsgPluggableMailStore.copyMessages. r=mkmelin

Comment 33

[Ben Campbell]

Attachment: [checked in] 1612239-remove-nsIArray-from-nsIMsgFolder-getFoldersWithFlags-1.patch

Try run here:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=73c001bd8ef0ffb66925a4a5809c2d3b478c54ad

Comment 34

[Magnus Melin [:mkmelin]]

Comment on attachment 9154527 [details] [diff] [review]
[checked in] 1612239-remove-nsIArray-from-nsIMsgFolder-getFoldersWithFlags-1.patch

Review of attachment 9154527 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r=mkmelin

Comment 35

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d146b4e2061c
Remove nsIArray usage from nsIMsgFolder.getFoldersWithFlags(). r=mkmelin

Comment 36

[Ben Campbell]

Attachment: [checked in] 1612239-remove-nsIArray-from-nsIMsgFolder-markMessagesRead-et-al-1.patch

Try run here:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=b36d20f09a11e8a3af3076d85ba00c5da913613b

(I originally thought it was breaking a mochitest, but there's another try run without this patch which does the same)

Comment 37

[Magnus Melin [:mkmelin]]

Comment on attachment 9156605 [details] [diff] [review]
[checked in] 1612239-remove-nsIArray-from-nsIMsgFolder-markMessagesRead-et-al-1.patch

Review of attachment 9156605 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/imap/src/nsImapMailFolder.cpp
@@ -8392,5 @@
>  
>  NS_IMETHODIMP
> -nsImapMailFolder::SetJunkScoreForMessages(nsIArray *aMessages,
> -                                          const nsACString &aJunkScore) {
> -  NS_ENSURE_ARG(aMessages);

isn't this still needed, if one pass in null from js?

Comment 38

[Ben Campbell]

(In reply to Magnus Melin [:mkmelin] from comment #37)

isn't this still needed, if one pass in null from js?

No, on the C++ side it's a nsTArray<> reference now, so you can't pass in null (well, obviously you still pass null in from JS, but I'd guess the bindings either throw an error or pass it on as an empty array to the C++ side).

Anyway, there is only one JS use, and it always passes in an array containing exactly one message.

Comment 39

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/93610e507d37
Remove nsIArray use in nsIMsgFolder markMessagesRead, markMessagesFlagged, setLabelForMessages, setJunkScoreForMessages. r=mkmelin

Comment 40

[Magnus Melin [:mkmelin]]

Ah yes, passing in null will just give
NS_ERROR_XPC_CANT_CONVERT_PRIMITIVE_TO_ARRAY: Cannot convert primitive JavaScript value into an array

Comment 41

[Ben Campbell]

Attachment: [checked in] 1612239-remove-nsIArray-from-nsIMsgFolder-keywords-1.patch

The try run has a couple of fails, but I think they were already there without this patch...
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=ffc2c3fa4e6f227629fb66cdb6c4b0e3ab70840a

Comment 42

[Magnus Melin [:mkmelin]]

Comment on attachment 9166196 [details] [diff] [review]
[checked in] 1612239-remove-nsIArray-from-nsIMsgFolder-keywords-1.patch

Review of attachment 9166196 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 43

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4f1fac782b47
nsIArray removal in nsIMsgFolder addKeywordsToMessages()/removeKeywordsFromMessages(). r=mkmelin DONTBUILD

Comment 44

[Ben Campbell]

Attachment: 1612239-nsIArray-removal-nsIMsgFolder-deleteSubFolders-1.patch

This one is for nsIMsgFolder.deleteSubFolders(). Took the opportunity to change it into deleteSubFolder() as it only ever worked for single folders and it streamlines the code a little.

try run here (don't think this broke anything new, but I'm not 100% sure):
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=0c31b8e2116ffb1e4496385005617a0c7e8c799d

Comment 45

[Magnus Melin [:mkmelin]]

Comment on attachment 9170295 [details] [diff] [review]
1612239-nsIArray-removal-nsIMsgFolder-deleteSubFolders-1.patch

Review of attachment 9170295 [details] [diff] [review]:
-----------------------------------------------------------------

Seems like we're use deleting `this`, with an awkward API. I think we can avoid passing in the folder at all

Comment 46

[Ben Campbell]

Attachment: 1612239-nsIArray-removal-nsIMsgFolder-deleteSubFolders-2.patch

Take 2 - this version replaces nsIMsgFolder.deleteSubFolders() with nsIMsgFolder.deleteSelf().

Try run here:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=d27c52674486c244e419e1c6ff2f2170ba351c7d

One reply-in-advance:
nsImapMailFolder::RemoveSubFolder (now nsImapMailFolder::RemoveLocalSelf()) used to call DeleteStorage() twice, so the one I removed here was redundant. The other DeleteStorage() call is under nsMsgDBFolder::DeleteSelf().

Comment 47

[Magnus Melin [:mkmelin]]

Comment on attachment 9175393 [details] [diff] [review]
1612239-nsIArray-removal-nsIMsgFolder-deleteSubFolders-2.patch

Review of attachment 9175393 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

::: mailnews/imap/src/nsImapMailFolder.cpp
@@ +996,3 @@
>    nsresult rv;
> +  // Kill the local folder and its storage.
> +  rv = nsMsgDBFolder::DeleteSelf(nullptr);

this function body could just be

return nsMsgDBFolder::DeleteSelf(nullptr);

@@ +2252,5 @@
> +    if (deleteNoTrash) {
> +      rv = imapService->DeleteFolder(this, this, msgWindow, nullptr);
> +      nsMsgDBFolder::DeleteSelf(msgWindow);
> +    } else {
> +      bool confirm = false;

would move this down into the if where it's used

Comment 48

[Ben Campbell]

Attachment: [checked in] 1612239-nsIArray-removal-nsIMsgFolder-deleteSubFolders-3.patch

Comment 49

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d4333da4784f
nsIArray removal in nsIMsgFolder.deleteSubFolders(). r=mkmelin

Comment 50

[Magnus Melin [:mkmelin]]

Attachment: [checked in] bug1612239_nsIArray_nsIMsgPluggableStore.patch

Just mopping up a few cases of unneeded interface nsIArray referencing

Comment 51

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/879aab6ea595
remove stray unneeded nsIArray references from some idl files. r=benc

Comment 52

[Ben Campbell]

Attachment: [checked in] 1612239-nsIArray-removal-in-nsIMsgCopyService-1.patch

This one's quite a chunky big one, I'm afraid...
Gets rid of the nsIArray use in nsIMsgCopyService.

Try run seems good, I think:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=91f439e3a63896745a69be77a3b8682edab35d3d

Comment 53

[Magnus Melin [:mkmelin]]

Comment on attachment 9190135 [details] [diff] [review]
[checked in] 1612239-nsIArray-removal-in-nsIMsgCopyService-1.patch

Review of attachment 9190135 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=mkmelin

Comment 54

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fe318ec033d4
Remove nsIArray usage in nsIMsgCopyService.CopyMessages(). r=mkmelin

Comment 55

[Ben Campbell]

Attachment: [checked in] 1612239-nsIArray-removal-nsIMsgFolder-DownloadMessagesForOffline-1.patch

Another nice simple one (hopefully!)

try run here (I think it looks OK - second opinion welcome!):
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=2392be12ee6621b7f8d5eca187bb311c7b2d361e

Comment 56

[Magnus Melin [:mkmelin]]

Comment on attachment 9190203 [details] [diff] [review]
[checked in] 1612239-nsIArray-removal-nsIMsgFolder-DownloadMessagesForOffline-1.patch

Review of attachment 9190203 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

::: mailnews/base/public/nsIMsgFolder.idl
@@ +611,5 @@
>     * @returns an input stream to read the message from
>     */
>    nsIInputStream getMsgInputStream(in nsIMsgDBHdr aHdr, out boolean aReusable);
>  
> +  void DownloadMessagesForOffline(in Array<nsIMsgDBHdr> messages,

Let's change to lowercase d while we're here

Comment 57

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/45afc2caa6c1
Remove nsIArray usage in nsIMsgFolder.DownloadMessagesForOffline(). r=mkmelin

Comment 58

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a0847685cc04
followup - make eslint happy by documenting return types. rs=eslint DONTBUILD

Comment 59

[Magnus Melin [:mkmelin]]

Ah, that should have been followup for bug 1674645.

Comment 60

[Ben Campbell]

Attachment: [checked in] 1612239-nsIArray-removal-nsIMsgFolder-1.patch

Hopefully the last one in this bug!
There's still some internal nsIArray/nsIMutableArray use, but I'll take stock off all that in another bug once the IDL files are all dealt with.

try run:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=722cbb59f4467366dfa040dfa0bf8f5792367fcc

Comment 61

[Magnus Melin [:mkmelin]]

Comment on attachment 9191415 [details] [diff] [review]
[checked in] 1612239-nsIArray-removal-nsIMsgFolder-1.patch

Review of attachment 9191415 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, quite a massive one! r=mkmelin

Comment 62

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c2ddbcc4f197
Remove nsIArray usage from nsIMsgFolder. r=mkmelin

Comment 63

[aliledudiable]

So, which version is the earliest one with this change committed?