Closed Bug 161226 Opened 20 years ago Closed 20 years ago

extensibility hooks for mailnews FE, and IMAP back end.

Categories

(SeaMonkey :: MailNews: Message Display, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: sspitzer, Assigned: sspitzer)

References

()

Details

Attachments

(5 files, 3 obsolete files)

extensibility hooks for mailnews FE, and IMAP back end.

tracker bug to land some work bienvenu and I are doing.
this exposes some more backend functionality to the front end js code...
Comment on attachment 94271 [details] [diff] [review]
some backend db changes to expose api's

sr=sspitzer
Attachment #94271 - Flags: superreview+
Comment on attachment 94271 [details] [diff] [review]
some backend db changes to expose api's

r=cavin.
Attachment #94271 - Flags: superreview+ → review+
first patch checked in.
I was looking at http://climate/ for talkback data on a different bug, but I 
happened to notice that, in builds of 08/07, there are couple of new top crashes
occurring in mork code called from nsMsgDatabase::InitNewDB(). You might want 
to check whether those are related to these changes.
that was a corrupt build from the release team as a result of switching to gmake
but not building dependencies - it has absolutely nothing to do with this checkin.
Ah. Sorry. Nevermind.
well, I should say that this checkin did expose the dependency problem :-)
add a notification when Mime has finished downloading a message.
JF, can I get an r= for the mime changes (the add OnEndMsgDownloaded
notification) patch? thx.
Comment on attachment 94954 [details] [diff] [review]
add OnEndMsgDownloaded notification

R=ducarroz
Attachment #94954 - Flags: review+
these mostly add the ability to run custom imap commands and fetch custom imap
attributes - there are also hooks to know when a msg hdr has been downloaded,
and support for custom keywords.
Cavin, can I get an r= for the third patch, the "more extensibility hooks" one? thx.
Comment on attachment 94271 [details] [diff] [review]
some backend db changes to expose api's

sr=sspitzer
Attachment #94271 - Flags: superreview+
Comment on attachment 94954 [details] [diff] [review]
add OnEndMsgDownloaded notification

sr=sspitzer
Attachment #94954 - Flags: superreview+
Comment on attachment 94968 [details] [diff] [review]
more extensibility hooks, mostly for imap stuff

r=cavin. Looks good and I only see a tabbing issue in
nsImapFlagAndUidState::GetCustomFlags().
Attachment #94968 - Flags: review+
this patch cleans up some js exceptions that the other patches caused. Cavin,
can you review? thx.
Comment on attachment 94968 [details] [diff] [review]
more extensibility hooks, mostly for imap stuff

sr=sspitzer
Attachment #94968 - Flags: superreview+
Comment on attachment 94998 [details] [diff] [review]
patches to clean up some js exceptions

sr=sspitzer
Attachment #94998 - Flags: superreview+
note, still not ready for reviews.
Attachment #95201 - Attachment is obsolete: true
Attachment #95208 - Attachment is obsolete: true
Comment on attachment 95232 [details] [diff] [review]
patch, fix commandglue.js to use redirector based pref

sr=bienvenu - there's a tab here, I think:
+		    var m

and I coulda sworn I'd already checked in a couple of these changes (the ones
to msgHdrViewOverlay.js), but it all looks fine.
Attachment #95232 - Flags: superreview+
they aren't up yet, but see http://www.mozilla.org/mailnews/arch/index.html for 
links to documents about how to use these folder pane, message pane, thread 
pane, compose window, mail window extras.
Status: NEW → ASSIGNED
fixed.  any other issues will be spun up as new bugs.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Comment on attachment 95232 [details] [diff] [review]
patch, fix commandglue.js to use redirector based pref

> // what if I have two rows selected, and I hit delete, and so we load the next row.
> // what if I have commands that only enable where exactly one row is selected?

Well, in the IMAP delete model nothing happens when you delete multiple rows. A
pity that's not an option for other models.
Comment on attachment 95232 [details] [diff] [review]
patch, fix commandglue.js to use redirector based pref

> // you might not have a db view.  this can happen if
> // biff fires when the 3 pane is set to account central.
> if (!gDBView)
>   return;
> gDBView.onDeleteCompleted(true);

Do you want to call onDeleteCompleted when gDBView doesn't refer to the
specified folder?
Did this break third-party themes? See
[news://news.mozilla.org/3BB35EBC.7010007@mozilla.org].
One of these patches has caused bug 162981. I confirmed this by backing out the
following checkins:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=SeaMonkeyAll&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=08%2F14%2F2002+15%3A10&maxdate=08%2F14%2F2002+15%3A20&cvsroot=%2Fcvsroot

(I'm guessing this is attachment 95232 [details] [diff] [review], but I haven't checked)

After those checkins are reversed (with some hand-holding for a single
conflict), Mail/news once again loads with third-party themes with the XUL cache
enabled (the problem mentioned in bug 162981 does not occur if the XUL cache is
disabled).
SPAM: sorry for the spam. Just clarifying that the bug number is 162891 (I
transposed 8 and 9 two times... oops).
Comment on attachment 95232 [details] [diff] [review]
patch, fix commandglue.js to use redirector based pref

In (I think) ChangeFolderByUri why are there two sets of updates, one at the
beginning and one at the end (which doesn't get called for Account Central;
note that this bug affects SetUpToolbarButtons!)
I've created bugreport 163837, to address the real issue
behing the problem with missing .css files in theme files.
QA Contact: olgam → laurel
Blocks: blackbird
Please add the adt1.0.2 keyword when a branch patch is ready
the fix for this bug has landed on the trunk and the branch.
Keywords: fixed1.0.2
verified on commercial branch and commercial trunk.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.