1612291 - [Ubuntu] Youtube video controls are improperly displayed while in High Contrast

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Daniel Bodea [:danibodea]]

Attachment: youtube video controls arfe improperly displayed.png

Note

• The Youtube video controls are improperly displayed while in High Contrast on Ubuntu 18.

Affected versions

• Nightly v74.0a1
• Beta v73.0b11

Affected platforms

• Ubuntu 18

Steps to reproduce

1. Activate OS High Contrast mode.
2. Open browser.
3. Open a Youtube video.

Expected result

• Control buttons are properly displayed.

Actual result

• Control buttons are improperly displayed.

Regression range

14:43.94 INFO: No more inbound revisions, bisection finished.
14:43.94 INFO: Last good revision: 70ee38a87597c71c3e51f984a0dd4d7e46e3c02d
14:43.94 INFO: First bad revision: dbeea4db8edeac1d346210eccbd1ed0240d5f65f
14:43.94 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=70ee38a87597c71c3e51f984a0dd4d7e46e3c02d&tochange=dbeea4db8edeac1d346210eccbd1ed0240d5f65f

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Seems to come from Bug 1606036 - Implement high contrast mode in GTK. r=stransky
Emilio, can you take a look please?
Thanks.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Hi Daniel, do you know if this repros on Windows too?

Comment 3

[Daniel Bodea [:danibodea]]

Yes, of course. It only occurs on Ubuntu.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Even if you enable windows' high-contrast mode? That is odd

Comment 5

[Daniel Bodea [:danibodea]]

Attachment: youtube video controls look fine on Windows 10.png

Yes, I could not reproduce this on Windows 10. I have reverified on 2 other test machines. If you enable the Windows High Contrast feature and open a youtube video, the icons of the video controls are visible.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

That's just by chance because the buttons happen to be dark. Will fix.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1612291 - Fix two issues with themed widgets in high contrast mode. r=dholbert,morgan,#style

There were two issues with the existing code that we use to determine whether a
widget is styled or not.

First, it was using color == Color::transparent() instead of
color.is_transparent() to check for transparent backgrounds. That is not sound
as Color::transparent() is the literal value rgba(0, 0, 0, 0), not the
transparent keyword, so the equality check would fail.

The other issue is that this function was early-returning false if that check
was returning false. It is a bug for this function to early-return false, as it
makes the result of the function dependent of the order of the declarations.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45d010b66a48
Fix two issues with themed widgets in high contrast mode. r=heycam

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/45d010b66a48

Comment 10

[Daniel Bodea [:danibodea]]

This fix was verified on Nightly v76.0a1 from 2020-03-19 and Beta v75.0b6.