Perma early beta mochitest test_interfaces.html/test_worker_interfaces.html/test_serviceworker_interfaces.html failures when Gecko 74 merges to Beta on 2020-02-10
Categories
(Core :: DOM: Service Workers, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox72 | --- | unaffected |
firefox73 | --- | unaffected |
firefox74 | + | verified |
People
(Reporter: CosminS, Assigned: tt)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
[Tracking Requested - why for this release]:
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=286953993&repo=try&lineNumber=4051
https://treeherder.mozilla.org/logviewer.html#?job_id=286955686&repo=try
[task 2020-01-30T11:10:03.439Z] 11:10:03 INFO - TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface Symbol to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2020-01-30T11:10:03.439Z] 11:10:03 INFO - Buffered messages finished
[task 2020-01-30T11:10:03.440Z] 11:10:03 INFO - TEST-UNEXPECTED-FAIL | dom/serviceworkers/test/test_serviceworker_interfaces.html | false: If this is failing: DANGER, are you sure you want to expose the new interface SharedArrayBuffer to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2020-01-30T11:10:03.440Z] 11:10:03 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:277:18
[task 2020-01-30T11:10:03.441Z] 11:10:03 INFO - setupSW/window.onmessage@dom/serviceworkers/test/test_serviceworker_interfaces.html:31:11
[task 2020-01-30T11:10:03.442Z] 11:10:03 INFO - TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface Intl to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2020-01-30T11:10:03.442Z] 11:10:03 INFO - TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface Reflect to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2020-01-30T11:10:03.442Z] 11:10:03 INFO - TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface WeakSet to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2020-01-30T11:10:03.443Z] 11:10:03 INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-01-30T11:10:03.444Z] 11:10:03 INFO - TEST-UNEXPECTED-FAIL | dom/serviceworkers/test/test_serviceworker_interfaces.html | false: If this is failing: DANGER, are you sure you want to expose the new interface Atomics to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2020-01-30T11:10:03.445Z] 11:10:03 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:277:18
[task 2020-01-30T11:10:03.445Z] 11:10:03 INFO - setupSW/window.onmessage@dom/serviceworkers/test/test_serviceworker_interfaces.html:31:11
[task 2020-01-30T11:10:03.446Z] 11:10:03 INFO - TEST-PASS | dom/serviceworkers/test/test_serviceworker_interfaces.html | true: If this is failing: DANGER, are you sure you want to expose the new interface Promise to all webpages as a property on the service worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
Looks to be from Bug 1611046 https://hg.mozilla.org/mozilla-central/rev/21e6f8a6b086fe0b40ded08dbdc7fec6c49dc1d0
Reporter | ||
Comment 1•4 years ago
|
||
Updated•4 years ago
|
Reporter | ||
Comment 2•4 years ago
|
||
LE: This is from Bug 1599496 https://hg.mozilla.org/mozilla-central/rev/911bb8adb076
Sorry Perry for the spam. Could you please take a look over this Tom? Thank you.
Updated•4 years ago
|
Assignee | ||
Comment 3•4 years ago
|
||
Sorry, I thought there doesn't have a check for early Beta for interface tests. Will work on a fix for that.
Updated•4 years ago
|
Assignee | ||
Comment 4•4 years ago
|
||
Assignee | ||
Comment 5•4 years ago
|
||
Updated•4 years ago
|
Comment 6•4 years ago
|
||
After importing the patch these failures appeared: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&selectedJob=287296872&revision=c046f2e61192d55a1a633db1424fc93c4dd8f9c6&searchStr=mochitest
Failure log: TEST-UNEXPECTED-FAIL | dom/workers/test/test_worker_interfaces.html | false: Atomics should be defined on the global scope
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=287296872&repo=try&lineNumber=10840
[task 2020-02-03T11:16:53.504Z] 11:16:53 INFO - TEST-PASS | dom/workers/test/test_worker_interfaces.html | true: AggregateError should NOT be defined on the global scope
[task 2020-02-03T11:16:53.504Z] 11:16:53 INFO - Buffered messages finished
[task 2020-02-03T11:16:53.508Z] 11:16:53 INFO - TEST-UNEXPECTED-FAIL | dom/workers/test/test_worker_interfaces.html | false: Atomics should be defined on the global scope
[task 2020-02-03T11:16:53.508Z] 11:16:53 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:277:18
[task 2020-02-03T11:16:53.509Z] 11:16:53 INFO - workerTestExec/worker.onmessage@dom/workers/test/worker_driver.js:35:9
[task 2020-02-03T11:16:53.509Z] 11:16:53 INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-02-03T11:16:53.509Z] 11:16:53 INFO - TEST-UNEXPECTED-FAIL | dom/workers/test/test_worker_interfaces.html | false: SharedArrayBuffer should be defined on the global scope
[task 2020-02-03T11:16:53.509Z] 11:16:53 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:277:18
[task 2020-02-03T11:16:53.509Z] 11:16:53 INFO - workerTestExec/worker.onmessage@dom/workers/test/worker_driver.js:35:9
[task 2020-02-03T11:16:53.509Z] 11:16:53 INFO - TEST-PASS | dom/workers/test/test_worker_interfaces.html | true: TypedObject should NOT be defined on the global scope
Could we follow these failures on this bug, or should we file a separate one?
Thank you.
Updated•4 years ago
|
Pushed by ttung@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4afc40783122 Correct the channels for Atmoics and SharedArrayBuffer in interfaces mochitests; r=annevk
Comment 8•4 years ago
|
||
bugherder |
Updated•4 years ago
|
Comment 10•4 years ago
•
|
||
As mentioned in comment 6 this has introduced a new perma failure on the late beta simulation:
dom/workers/test/test_worker_interfaces.html | false: Atomics should be defined on the global scope
dom/workers/test/test_worker_interfaces.html | false: SharedArrayBuffer should be defined on the global scope
dom/workers/test/test_worker_interfaces.html | 2 === 0: The following interface(s) are not enumerated: Atomics, SharedArrayBuffer
Assignee | ||
Comment 12•4 years ago
|
||
(In reply to Bogdan Tara[:bogdan_tara | bogdant] from comment #10)
As mentioned in comment 6 this has introduced a new perma failure on the late beta simulation:
dom/workers/test/test_worker_interfaces.html | false: Atomics should be defined on the global scope
dom/workers/test/test_worker_interfaces.html | false: SharedArrayBuffer should be defined on the global scope
dom/workers/test/test_worker_interfaces.html | 2 === 0: The following interface(s) are not enumerated: Atomics, SharedArrayBuffer
Hmm, for some reason, I cannot reproduce this locally. (I was able to reproduce the original issue after applying the central-as-beta patch)
Reporter | ||
Comment 13•4 years ago
|
||
Tom, this only happens on late beta, on early beta the jobs are green, and I suspect it's from https://hg.mozilla.org/mozilla-central/rev/4afc407831226e76ce0f4549b37ef446f99ada02#l1.13.
Try to apply the late beta changes like: https://hg.mozilla.org/try/rev/cb96a9869001ff69eac472a88c78ca372dfe7a0b and maybe it's helps reproducing the failures.
Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=287435204&repo=try&lineNumber=4705
Assignee | ||
Comment 14•4 years ago
|
||
(In reply to Tom Tung [:tt, :ttung] from comment #12)
Hmm, for some reason, I cannot reproduce this locally. (I was able to reproduce the original issue after applying the central-as-beta patch)
I'm pulling the revision c046f2e61192 for try and building that locally. We will see if I can reproduce it or not.
Assignee | ||
Comment 15•4 years ago
|
||
(In reply to Cosmin Sabou [:CosminS] from comment #13)
I copied the changes in https://hg.mozilla.org/try/rev/cb96a9869001ff69eac472a88c78ca372dfe7a0b manually and applied my patch on the top of that. However, I couldn't reproduce that. Maybe I somehow miss something accidentally.
As I mentioned in comment#14, I guess I should be able to reproduce the issue in this way.
Assignee | ||
Comment 16•4 years ago
|
||
(In reply to Cosmin Sabou [:CosminS] from comment #13)
Tom, this only happens on late beta, on early beta the jobs are green, and I suspect it's from https://hg.mozilla.org/mozilla-central/rev/4afc407831226e76ce0f4549b37ef446f99ada02#l1.13.
This is a bug (typo), but not sure if it's the root cause. I will fix that here anyway.
Assignee | ||
Comment 17•4 years ago
|
||
(In reply to Tom Tung [:tt, :ttung] from comment #16)
(In reply to Cosmin Sabou [:CosminS] from comment #13)
Tom, this only happens on late beta, on early beta the jobs are green, and I suspect it's from https://hg.mozilla.org/mozilla-central/rev/4afc407831226e76ce0f4549b37ef446f99ada02#l1.13.
This is a bug (typo), but not sure if it's the root cause. I will fix that here anyway.
I can reproduce that and it's because there is another typos on worker tests (Anne caught that actually).
Assignee | ||
Comment 18•4 years ago
|
||
Assignee | ||
Comment 19•4 years ago
|
||
(Applying this patch fixes the issue on my Mac)
Comment 20•4 years ago
|
||
Importing the patch solves the beta sim failures: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=81db070f9945c293baca4fa4b469a8ea8b08e0c8
Reporter | ||
Comment 21•4 years ago
|
||
Anne, could you please review the patch from Tom so we can have this landed before the m-c merge to beta? Thank you.
Comment 22•4 years ago
|
||
Thanks for the heads up, done. Sometimes Phabricator requests don't show up anywhere for me...
Comment 23•4 years ago
|
||
Pushed by ttung@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c3712eef8efb Fix a set of typos on interface mochitests; r=annevk
Comment 24•4 years ago
|
||
bugherder |
Comment 26•4 years ago
•
|
||
.
Comment hidden (Intermittent Failures Robot) |
Description
•