Closed Bug 1612385 Opened 4 years ago Closed 4 years ago

Check if loadInfo->GetTopLevelPrincipal in IsFirstPartyStorageAccessGrantedFor works in Fission mode

Categories

(Core :: Privacy: Anti-Tracking, task, P1)

Product:
Core
Component:
Privacy: Anti-Tracking
Type:
task

Tracking

()

Status:
RESOLVED INVALID
Project Flags:
Fission Milestone M6a

People

(Reporter: dimi, Unassigned)

References

Details

We use loadInfo->GetTopLevelPrincipal to get top-level principal in IsFirstPartyStorageAccessGrantedFor.
We need to check if this API is currently fission compatible

See Bug 1587743 Comment 3, this probably work in Fission. But see Bug 1587743 comment 6, this could change in the future since this behavior is considered buggy in Fission.

Tracking for Fission dogfooding (M5)

IIUC, this bug depends on Anny's fix for TYPE_DOCUMENT bug 1594529.

Fission Milestone: --- → M5
Depends on: 1594529
Blocks: 1616788
No longer blocks: 1599048

Tracking for Fission Nightly (M6). This bug doesn't need to block M5 Dogfooding.

Nika says GetTopLevelPrincipal() probably will work here as-is, but it won't work early during the life cycle. mwoodrow filed a bug to delay setting loadInfo until we have all the information to fully initialize it.

Fission Milestone: M5 → M6
Summary: Check if loadInfo->GetTopLevelPrincipal works in fission mode → Check if loadInfo->GetTopLevelPrincipal in IsFirstPartyStorageAccessGrantedFor works in Fission mode

Tentatively moving P1 Fission M6 bugs to M6a.

Fission Milestone: M6 → M6a

We have replaced all the places using toplevelWindow in IsFirstPartyStorageAccessGrantedFor (the new naming is ShouldAllowAccessFor).
We can close this bug now.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.