Open Bug 1612386 Opened 6 months ago Updated 6 months ago

Don't always update lastRelatedTab information when browser.tabs.insertAllTabsAfterCurrent is true

Categories

(SeaMonkey :: Tabbed Browser, defect)

defect
Not set
normal

Tracking

(Not tracked)

ASSIGNED

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

(Regression)

Details

Attachments

(1 file)

Bug 1353428 add a pref for opening all new tabs after the current tab. lastRelatedTab information should not be updated when the current tab is not related.

[Approval Request Comment]
Regression caused by (bug #): 1353428
User impact if declined: lastRelated gets updated when it shouldn't
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Attachment #9123714 - Flags: review?(frgrahl)
Attachment #9123714 - Flags: approval-comm-release?
Attachment #9123714 - Flags: approval-comm-esr60?
Comment on attachment 9123714 [details] [diff] [review]
Don't always update lastRelated

Cancelling review as per irc discussion.
Apparantly causes problems with tab order in session restore if browser.tabs.insertAllTabsAfterCurrent is set to true. Seems to reverse the order because tabs are always inserted after the first tab.
Attachment #9123714 - Flags: review?(frgrahl)
Attachment #9123714 - Flags: approval-comm-release?
Attachment #9123714 - Flags: approval-comm-esr60?
You need to log in before you can comment on or make changes to this bug.