1612403 - File extensions are duplicated for file inputs with custom 'accept'

Status: RESOLVED FIXED

(Firefox :: File Handling, defect, P2)

Description

[gserg.g]

Attachment: file types.png

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:72.0) Gecko/20100101 Firefox/72.0

Steps to reproduce:

Firefox 72 on Windows 7 and Windows 10.

Given a file input element with a custom 'accept' attribute:

<input type="file" name="file" accept="application/pdf,application/msword,application/vnd.openxmlformats-officedocument.wordprocessingml.document,application/vnd.ms-excel,application/vnd.openxmlformats-officedocument.spreadsheetml.sheet,text/plain" multiple="multiple">

Actual results:

When clicked, a file dialog is displayed where the file extensions are duplicated in both the "All supported types" item and in the individual file type items (see screenshot):

All Supported Types (.pdf;.pdf;.doc;.doc;.docx;.docx;.xls;.xls;.xlsx;.xlsx;.txt.txt)
Adobe Acrobat Document (.pdf;.pdf)
Microsoft Word 97 - 2003 Document (.doc;.doc)
Microsoft Word Document (.docx;.docx)
Microsoft Excel 97-2003 Worksheet (.xls;.xls)
Microsoft Excel Worksheet (.xlsx;.xlsx)
Text Document (.txt;.txt)

Expected results:

File extensions in the file types list are not duplicated:

All Supported Types (.pdf; .doc; .docx; .xls; .xlsx; .txt)
Adobe Acrobat Document (.pdf)
Microsoft Word 97 - 2003 Document (.doc)
Microsoft Word Document (.docx)
Microsoft Excel 97-2003 Worksheet (.xls)
Microsoft Excel Worksheet (.xlsx)
Text Document (.txt)

Comment 1

[Augusto Pace]

Hi,

I was able to reproduce this issue on Windows 10 for Firefox version Nightly 74.0a1 (2020-02-03) (64-bit) - Beta 73.0b11 (64-bit) - Release 72.0.2 (64-bit). Marking those flags as affected.

Also I'm setting the component to Firefox - File Handling and status to new for someone to take a look at this.

Comment 2

[Marco Bonardo [:mak]]

https://searchfox.org/mozilla-central/source/uriloader/exthandler/HandlerService.js#432-436
https://searchfox.org/mozilla-central/source/uriloader/exthandler/nsMIMEInfoImpl.cpp#146

Comment 3

[Marco Bonardo [:mak]]

Attachment: Bug 1612403 - File extensions are duplicated for file inputs with custom 'accept'. r=Gijs

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8eb23bb2215a
File extensions are duplicated for file inputs with custom 'accept'. r=Gijs

Comment 5

[Dorel Luca [:dluca]]

Backed out changeset 8eb23bb2215a (bug 1612403) for Build bustage in android/nsMIMEInfoAndroid.cpp. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=289252267&repo=autoland&lineNumber=20065

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=8eb23bb2215a1af6196f182e06932430165f20da

Backout:
https://hg.mozilla.org/integration/autoland/rev/bb6ad1aeeacc07cecf1b13c479f66ede635e9b58

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a121aa7d527
File extensions are duplicated for file inputs with custom 'accept'. r=Gijs

Comment 7

[Andreea Pavel [:apavel]]

Backed out for android crashes at @ nsMIMEInfoAndroid::SetPrimaryExtension(nsTSubstring<char> const&)

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=0a121aa7d5276f109ab16d797745d2d226edb2dc&selectedJob=289271873

Tier1 failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=289277918&repo=autoland&lineNumber=2151

Backout: https://hg.mozilla.org/integration/autoland/rev/3442b55d354602128b08f96c6a266bbec2a2c8cb

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cfea5c3c067
File extensions are duplicated for file inputs with custom 'accept'. r=Gijs

Comment 9

[Andreea Pavel [:apavel]]

Backed out for failing test_bug449141.html

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=289655029&resultStatus=testfailed%2Cbusted%2Cexception&revision=3cfea5c3c067c9515a5ba2ffc4d5e6a26f882726

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=289655029&repo=autoland&lineNumber=58067

Backout: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=289655029&repo=autoland&lineNumber=58067

Comment 10

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f769fd5cefcb
Backed out changeset 3cfea5c3c067 for failing test_bug449141.html on a CLOSED TREE

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/065f8b63d920
File extensions are duplicated for file inputs with custom 'accept'. r=Gijs

Comment 12

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/065f8b63d920

Comment 13

[Julien Cristau [:jcristau] (back April 22)]

I guess this can ride the trains to 75?