1612460 - Focus can be taken from iframe without visual indication

Status: RESOLVED INVALID

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[anoakie]

Attachment: Demonstration of the iframe/textarea input focus issue

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:74.0) Gecko/20100101 Firefox/74.0

Steps to reproduce:

1. I went to youtube.com while using the Mix extension - https://addons.mozilla.org/en-US/firefox/addon/mix-ext/ - The extension works by injecting an iframe into the page. This iframe has a "share" feature that has a textarea that allows the user to respond to or send a share.
2. I clicked to focus the textarea in the iframe, which resulted in the blinking cursor inside the iframe's textarea
3. I attempted to type into the iframe's textarea

Note - This isn't readily reproducible. I was able to produce it about 50% of the time.
This might be related to click-jacking protection with iframes

Actual results:

Each key press was captured by youtube instead of the iframe even though the cursor was still blinking in the textarea. You can see the youtube video pausing/playing/changing in the attached clip.

Expected results:

The <textarea> in iframe, which should have had focus and did have the blinking cursor, should have captured the key presses

Comment 1

[Marcela (Please NI request to Brindusa Tot)]

Hi anoakie!
I was unable to reproduce this issue on latest Noghlty version 74.0a1 (2020-02-03) on macOS 10.15.
Could you please add the about:support data to this bug? (Help > troubleshooting information > click "copy raw data to clipboard" button, then go to https://bugzilla.mozilla.org/attachment.cgi?bugid=1612460&action=enter and paste it as an attachment (instead of browsing to a file) ).
I've chosen a component for this bug so that the developers may look at it. We'll wait for their answer. If you consider that there's another component that's more proper for this case you may change it.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

I think this was fixed in bug 1595435.

Comment 3

[anoakie]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

I think this was fixed in bug 1595435.

@emilio Yes, it looks like their test case reproduces the issue that I'm seeing: https://bugzilla.mozilla.org/attachment.cgi?id=9116416

I'm not sure it's fixed. Maybe there was a regression or something. I can still reproduce it on the Nightly build: 75.0a1 (2020-02-11) (64-bit)

Comment 4

[John Dai[:jdai]]

(In reply to anoakie from comment #3)

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

I think this was fixed in bug 1595435.

@emilio Yes, it looks like their test case reproduces the issue that I'm seeing: https://bugzilla.mozilla.org/attachment.cgi?id=9116416

I'm not sure it's fixed. Maybe there was a regression or something. I can still reproduce it on the Nightly build: 75.0a1 (2020-02-11) (64-bit)

Dear Reporter,

I can't reproduce from your test (https://bugzilla.mozilla.org/attachment.cgi?id=9116416). I'm using Nightly build: 75.0a1 and without using Mix extension. If it's still happened to you, please file a bug to Mix extension. Feel free to re-open if you think the bug is from the Firefox side. Thank you.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Well they're reporting an issue that happens when you use an extension (which they develop I suspect), and that is likely to be a Gecko bug... I think closing as WFM is not great.

Reporter, I can't repro with the test-case from https://bug1595435.bmoattachments.org/attachment.cgi?id=9116416, can you elaborate on how you got it to reproduce with nightly? Maybe an screencast or something? Or do you mean that the issue described in comment 0 still reproduces?

Comment 6

[anoakie]

Attachment: Screen Recording 2020-02-12 at 8.52.17 AM.mov

Demo with the Mix extension

I reload the page, click into the text area in the iframe to focus it, and start hitting "k".

After a second, youtube takes the focus from the iframe (as seen where the video starts pausing/unpausing)

Comment 7

[anoakie]

Attachment: Screen Recording 2020-02-12 at 8.46.37 AM.mov

Demo with the test case posted above

I reload the page, click into the input in the iframe to focus it, and start hitting "f".

After a second, the parent page takes the focus from the iframe. I'm still hitting "f", but the #focusme element on the top page now has focus, so the input in the iframe no longer has focus.

Comment 8

[Emilio Cobos Álvarez [:emilio]]

That is the expected behavior and the behavior in other browsers... Before that there used to be a focus change, but the input still appeared focused.

Comment 9

[anoakie]

If this is expected behavior, then I'll close the bug as INVALID. Thank you for your help!