1612483 - Can we remove mozilla::dom::TabContext::IsMozBrowser()?

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, task)

Description

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Now, this method returns simply the result of of IsMozBrowserElement(), there are not many usages, and I feel there is no semantically difference by the comment.

I'm not sure about the historical reason which we have IsMozBrowser() and IsMozBrowserElement(), but I seem we can remove the former now by replacing all IsMozBrowser() to IsMozBrowserElement() as simply refactoring.

This suspicion is right?

Comment 1

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

How do you think about this?

Comment 2

[Boris Zbarsky [:bzbarsky]]

(Sorry for the lag on this; was traveling.)

I'm not sure about the historical reason which we have IsMozBrowser() and IsMozBrowserElement()

We used to have IsMozBrowserElement and IsMozBrowserOrApp, where the latter was true if we had a mozapp or mozbrowser. With b2g removed, the app thing went away.

I am fine with eliminating one of these methods; don't much care which one. Of course I also think we should remove mozbrowser altogether...

Comment 3

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

(In reply to Boris Zbarsky [:bzbarsky, bz on IRC] from comment #2)

(Sorry for the lag on this; was traveling.)

I'm not sure about the historical reason which we have IsMozBrowser() and IsMozBrowserElement()

We used to have IsMozBrowserElement and IsMozBrowserOrApp, where the latter was true if we had a mozapp or mozbrowser. With b2g removed, the app thing went away.

I am fine with eliminating one of these methods; don't much care which one. Of course I also think we should remove mozbrowser altogether...

Thank you for you response. (No problem for the lag)
I'll create a patch to replace IsMozBrowser() with IsMozBrowserElement()

Comment 4

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: Bug 1612483 - Remove mozilla::dom::TabContext::IsMozBrowser().

Now, this method returns simply the result of of IsMozBrowserElement().

In the old days, We used to have IsMozBrowserElement and IsMozBrowserOrApp,
where the latter was true if we had a mozapp or mozbrowser.
But with b2g removed, the app thing went away.

IsMozBrowser() is less used than IsMozBrowserElement().

I think the former should be replaced by the later one.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9246a8ba73d8
Remove mozilla::dom::TabContext::IsMozBrowser(). r=bzbarsky

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9246a8ba73d8